Fix optimized binary op broadcast rank mismatch

[Kilbex]

Summary

The optimized last-dimension and planned broadcast paths resize out to one input's shape after the operator has already selected the broadcast target. When leading dimensions of size one make the target rank larger, that second resize tries to change the immutable rank and fails at runtime.

Resize out to the broadcast target in both paths and add regression coverage for add and mul in both argument orders.

Fixes #10959

Test plan

./cmake-out/kernels/test/optimized_kernels_test --gtest_brief=1

lintrunner kernels/optimized/cpu/binary_ops.cpp kernels/optimized/cpu/binary_ops.h kernels/test/op_add_test.cpp kernels/test/op_mul_test.cpp

cc @larryliu0820 @manuelcandales

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21052

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• Unrelated MacOS MPS test jobs time out (30 min) due to stale cpp_extension lock file poisoning self-hosted runners

✅ No Failures

As of commit c13e4a6 with merge base 5828778 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[meta-cla]

Hi @Kilbex!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Kilbex / name: Maya Bennett (c10d441)

[Kilbex]

@pytorchbot label "release notes: ops & kernels"

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!