Skip to content

Reland two-pass channelwise gated delta rule kernel + OSS-safe bench BUCK#21105

Open
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D113076546
Open

Reland two-pass channelwise gated delta rule kernel + OSS-safe bench BUCK#21105
JakeStevens wants to merge 1 commit into
pytorch:mainfrom
JakeStevens:export-D113076546

Conversation

@JakeStevens

Copy link
Copy Markdown
Contributor

Summary:
Relands the two-pass optimization for the channelwise_gated_delta_rule custom op (originally #21020, D112596724), which was reverted in D113048961 because it broke OSS unittest macos / linux.

The revert was caused by the benchmark BUCK target:

runtime.python_binary(name = ..., srcs = [...], main_module = ...)

Fix: move the source into a runtime.python_library and have the runtime.python_binary reference it via deps with only main_module

Differential Revision: D113076546

…BUCK

Summary:
Relands the two-pass optimization for the `channelwise_gated_delta_rule` custom op (originally pytorch#21020, D112596724), which was reverted in D113048961 because it broke OSS `unittest macos / linux`.

The revert was caused by the benchmark BUCK target:
```
runtime.python_binary(name = ..., srcs = [...], main_module = ...)
```


Fix: move the source into a `runtime.python_library` and have the `runtime.python_binary` reference it via `deps` with only `main_module`

Differential Revision: D113076546
@pytorch-bot

pytorch-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21105

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit da0f64d with merge base 666ba0b (image):

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / hifi4 (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the ci-no-td label Jul 21, 2026
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2026
@meta-codesync

meta-codesync Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113076546.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant