Reland two-pass channelwise gated delta rule kernel + OSS-safe bench BUCK#21105
Reland two-pass channelwise gated delta rule kernel + OSS-safe bench BUCK#21105JakeStevens wants to merge 1 commit into
Conversation
…BUCK Summary: Relands the two-pass optimization for the `channelwise_gated_delta_rule` custom op (originally pytorch#21020, D112596724), which was reverted in D113048961 because it broke OSS `unittest macos / linux`. The revert was caused by the benchmark BUCK target: ``` runtime.python_binary(name = ..., srcs = [...], main_module = ...) ``` Fix: move the source into a `runtime.python_library` and have the `runtime.python_binary` reference it via `deps` with only `main_module` Differential Revision: D113076546
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21105
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New FailuresAs of commit da0f64d with merge base 666ba0b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113076546. |
This PR needs a
|
Summary:
Relands the two-pass optimization for the
channelwise_gated_delta_rulecustom op (originally #21020, D112596724), which was reverted in D113048961 because it broke OSSunittest macos / linux.The revert was caused by the benchmark BUCK target:
Fix: move the source into a
runtime.python_libraryand have theruntime.python_binaryreference it viadepswith onlymain_moduleDifferential Revision: D113076546