Qualcomm AI Engine Direct - Update quant recipe for PyTorch version bump#21237
Open
DannyYuyang-quic wants to merge 1 commit into
Open
Qualcomm AI Engine Direct - Update quant recipe for PyTorch version bump#21237DannyYuyang-quic wants to merge 1 commit into
DannyYuyang-quic wants to merge 1 commit into
Conversation
After the PyTorch version bump, the module path changed from layers.0.attention.wv_conv to layers.0.attention.forward.__self__.wv_conv Because of this, the existing regex r"layers\..*\.attention\.wv.*" no longer matches and the tag is missed. Updating it to r"layers\..*\.attention\..*wv.*" will cover both formats.
DannyYuyang-quic
requested review from
abhinaykukkadapu and
psiddh
as code owners
July 23, 2026 03:35
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21237
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below:
|
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
@pytorchbot label "release notes: qualcomm" |
pytorch-bot
Bot
added
the
release notes: qualcomm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the PyTorch version bump, the module path changed from layers.0.attention.wv_conv to layers.0.attention.forward.self.wv_conv Because of this, the existing regex r"layers...attention.wv." no longer matches and the tag is missed. Updating it to r"layers..*.attention..wv." will cover both formats.
Test plan
LLM CI
cc: @psiddh @shewu-quic @haowhsu-quic @winskuo-quic