migrate backends/apple/coreml (TARGETS+BUCK both with rules) (#21429) by bigfootjon · Pull Request #21429 · pytorch/executorch

bigfootjon · 2026-07-28T16:15:54Z

Summary:

TARGETS contained fbcode-only Python rules (placeholder backend imports);
BUCK contained xplat-only Apple platform cxx_library targets. Created a
new targets.bzl with define_common_targets(is_fbcode = False) whose body
splits via if/else: fbcode branch holds the Python rules, xplat branch
holds the Apple cxx targets. Replaced BUCK with thin caller, deleted
TARGETS.

Reviewed By: ndmitchell

Differential Revision: D109082057

pytorch-bot · 2026-07-28T16:15:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21429

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 143 Pending

As of commit 11e356a with merge base d8c6be2 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2026-07-28T16:16:47Z

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109082057.

github-actions · 2026-07-28T16:18:09Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull request overview

This PR continues the migration away from standalone TARGETS files by consolidating fbcode-only and xplat-only Buck targets into targets.bzl (with define_common_targets(is_fbcode=...)) and switching directories to a thin BUCK caller that gates behavior via is_fbcode().

Changes:

Introduce/extend define_common_targets(is_fbcode = False) patterns in several directories to preserve fbcode-vs-xplat behavior while deleting TARGETS.
Add thin BUCK entrypoints that call define_common_targets(is_fbcode = is_fbcode()).
Migrate backends/apple/coreml to a single targets.bzl with explicit fbcode/xplat branching and simplify its BUCK.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
extension/pytree/test/targets.bzl	New gated target definitions (fbcode-only) moved out of `TARGETS`.
extension/pytree/test/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
extension/pytree/test/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
examples/models/llama/config/targets.bzl	Gate existing unittest target definitions on `is_fbcode`.
examples/models/llama/config/TARGETS	Deleted; migration to BUCK+targets.bzl calling convention.
examples/models/llama/config/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
backends/cuda/tests/targets.bzl	New gated CUDA test target definitions moved out of `TARGETS`.
backends/cuda/tests/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
backends/cuda/tests/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
backends/cuda/runtime/targets.bzl	New gated CUDA runtime + tests target definitions moved out of `TARGETS`.
backends/cuda/runtime/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
backends/cuda/runtime/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
backends/cuda/runtime/shims/tests/targets.bzl	Update common-targets entrypoint to accept `is_fbcode` gating.
backends/cuda/runtime/shims/tests/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
backends/cuda/runtime/shims/tests/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
backends/apple/coreml/targets.bzl	New combined fbcode/xplat target definitions with explicit branch split.
backends/apple/coreml/TARGETS	Deleted after moving fbcode Python rules into `targets.bzl`.
backends/apple/coreml/BUCK	Reduced to a thin caller into `targets.bzl` gated by `is_fbcode()`.
backends/aoti/tests/targets.bzl	New gated AOTI test target definitions moved out of `TARGETS`.
backends/aoti/tests/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
backends/aoti/tests/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
backends/aoti/slim/factory/test/targets.bzl	Gate existing slim factory tests on `is_fbcode` to preserve prior behavior.
backends/aoti/slim/factory/test/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
backends/aoti/slim/factory/test/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+            ":cuda_platform",
+            ":runtime_shims",
+            ":cuda_allocator",
+            ":cuda_platform",
+            "//executorch/backends/aoti:aoti_common_slim",


+            "//executorch/extension/tensor:tensor",
+        ],


 load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
 load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")



+load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
+load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
+load("@fbcode_macros//build_defs:python_unittest_remote_gpu.bzl", "python_unittest_remote_gpu")
+load("@fbcode_macros//build_defs/lib:re_test_utils.bzl", "re_test_utils")
+


ndmitchell

Review automatically exported from Phabricator review in Meta.

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

backends/apple/coreml/targets.bzl:15

This comment is now redundant/misleading inside targets.bzl (it says targets must be defined in targets.bzl). Since this file itself is targets.bzl and the branch is specifically fbcode-only, it would be clearer to replace it with a short branch-specific note.

        # Any targets that should be shared between fbcode and xplat must be defined in
        # targets.bzl. This file can contain fbcode-only targets.

backends/apple/coreml/BUCK:2

The top-of-file comment still describes targets.bzl as holding only shared targets, but the current setup delegates all targets (including fbcode-only/xplat-only branches) to targets.bzl. Updating the comment would avoid confusion for future maintainers.

# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl.

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

runtime/core/BUCK:4

This PR changes runtime/core/BUCK to load its target definitions from @fbsource//xplat/executorch/runtime/core:targets.bzl (shim_et in OSS), which is a broader migration than the PR description (focused on CoreML) indicates. Consider adding a brief note here clarifying why the targets live in the xplat shim to avoid confusion for future maintainers.

# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.

load("@fbsource//xplat/executorch/runtime/core:targets.bzl", "define_common_targets")

This enables #21429 to work correctly (see failing BUCK CI job there) It's currently failing due to `targets.bzl` being exported from Meta to the wrong location. This fixes that on GH.

…#21429) Summary: TARGETS contained fbcode-only Python rules (placeholder backend imports); BUCK contained xplat-only Apple platform cxx_library targets. Created a new targets.bzl with define_common_targets(is_fbcode = False) whose body splits via if/else: fbcode branch holds the Python rules, xplat branch holds the Apple cxx targets. Replaced BUCK with thin caller, deleted TARGETS. Reviewed By: ndmitchell Differential Revision: D109082057

…#21429) Summary: Pull Request resolved: pytorch#21429 TARGETS contained fbcode-only Python rules (placeholder backend imports); BUCK contained xplat-only Apple platform cxx_library targets. Created a new targets.bzl with define_common_targets(is_fbcode = False) whose body splits via if/else: fbcode branch holds the Python rules, xplat branch holds the Apple cxx targets. Replaced BUCK with thin caller, deleted TARGETS. Reviewed By: ndmitchell Differential Revision: D109082057

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

…#21429) Summary: TARGETS contained fbcode-only Python rules (placeholder backend imports); BUCK contained xplat-only Apple platform cxx_library targets. Created a new targets.bzl with define_common_targets(is_fbcode = False) whose body splits via if/else: fbcode branch holds the Python rules, xplat branch holds the Apple cxx targets. Replaced BUCK with thin caller, deleted TARGETS. Reviewed By: ndmitchell Differential Revision: D109082057

Copilot AI review requested due to automatic review settings July 28, 2026 16:15

bigfootjon requested review from JacobSzwejbka and shoumikhin as code owners July 28, 2026 16:15

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2026

meta-codesync Bot added the meta-exported label Jul 28, 2026

meta-codesync Bot had a problem deploying to cadence July 28, 2026 16:16 Failure

Copilot started reviewing on behalf of bigfootjon July 28, 2026 16:16 View session

Copilot AI reviewed Jul 28, 2026

View reviewed changes

ndmitchell approved these changes Jul 28, 2026

View reviewed changes

SS-JIA approved these changes Jul 29, 2026

View reviewed changes

bigfootjon mentioned this pull request Jul 30, 2026

Move targets.bzl to proper location #21495

Merged

bigfootjon force-pushed the export-D109082057 branch from a0ef20e to 30c7481 Compare July 30, 2026 16:19

Copilot AI review requested due to automatic review settings July 30, 2026 16:19

Copilot started reviewing on behalf of bigfootjon July 30, 2026 16:20 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 30, 2026 16:26

bigfootjon force-pushed the export-D109082057 branch from 30c7481 to c3b54a4 Compare July 30, 2026 16:26

Copilot started reviewing on behalf of bigfootjon July 30, 2026 16:29 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

meta-codesync Bot changed the title ~~migrate backends/apple/coreml (TARGETS+BUCK both with rules)~~ migrate backends/apple/coreml (TARGETS+BUCK both with rules) (#21429) Jul 31, 2026

Copilot AI review requested due to automatic review settings July 31, 2026 15:41

bigfootjon force-pushed the export-D109082057 branch from c3b54a4 to c67db23 Compare July 31, 2026 15:41

Copilot started reviewing on behalf of bigfootjon July 31, 2026 15:42 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

bigfootjon force-pushed the export-D109082057 branch from c67db23 to 11e356a Compare July 31, 2026 15:45

meta-codesync Bot merged commit 9c3dfd9 into pytorch:main Jul 31, 2026
194 of 196 checks passed

Navigation Menu

Uh oh!

migrate backends/apple/coreml (TARGETS+BUCK both with rules) (#21429) - #21429

migrate backends/apple/coreml (TARGETS+BUCK both with rules) (#21429)#21429
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
bigfootjon:export-D109082057

bigfootjon commented Jul 28, 2026 •

edited by meta-codesync Bot

Loading

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

ndmitchell left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
		load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")

Uh oh!

Conversation

bigfootjon commented Jul 28, 2026 • edited by meta-codesync Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21429

⏳ No Failures, 143 Pending

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

This PR needs a release notes: label

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

ndmitchell left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bigfootjon commented Jul 28, 2026 •

edited by meta-codesync Bot

Loading

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

This PR needs a `release notes:` label