Repository navigation
Qualcomm AI Engine Direct - add Windows-on-device execution support to Device (formerly SimpleADB) - #22795
Draft
chenweng-quic wants to merge 1 commit into
Draft
Qualcomm AI Engine Direct - add Windows-on-device execution support to Device (formerly SimpleADB)#22795chenweng-quic wants to merge 1 commit into
chenweng-quic wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22795
Note: Links to docs will display an error until the docs builds have been completed.
|
This PR needs a
|
chenweng-quic
marked this pull request as ready for review
September 15, 2026 01:49
chenweng-quic
requested review from
abhinaykukkadapu and
psiddh
as code owners
September 15, 2026 01:49
chenweng-quic
marked this pull request as draft
September 17, 2026 06:21
chenweng-quic
force-pushed
the
dev1/chenweng/support_windows_in_python_script
branch
from
October 7, 2026 02:00
b386d2c to
7c77c2f
Compare
chenweng-quic
marked this pull request as ready for review
October 7, 2026 02:00
chenweng-quic
marked this pull request as draft
October 7, 2026 03:03
Add a DeviceBridge abstraction with ADB for Android and OE-Linux targets and WindowsBridge for local Windows-on-Snapdragon execution. Select the bridge from the configured target, stage Windows artifacts with local copies, run commands through PowerShell, and use target-specific runner and library names. Rename SimpleADB to Device across Qualcomm scripts, tests, and documentation. Update profiling integrations to use the public Device push, execute, and pull APIs. Co-authored with Codex (OpenAI).
chenweng-quic
force-pushed
the
dev1/chenweng/support_windows_in_python_script
branch
from
October 7, 2026 03:54
7c77c2f to
795e03c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Device(renamed fromSimpleADB) now dispatches to eitherADB(existing Android/OE-Linux over-adb behavior, restored) or the newLocalBridge(Windows-on-Snapdragon, where the CLI runs on-device already, so file staging is a local copy and commands run through PowerShell instead ofadb shell), selected automatically from--target.SimpleADB->Devicerename is mechanical across all call sites; two call sites that reached into the now-removed private_adbwere migrated to the existing publicpull/pull_heap_outputmethods.SimpleADBby name, and a couple of docstring lines that said "android device".(DeviceBridge/ADB/LocalBridge, library naming per target, Device.init);
everything else is the SimpleADB -> Device identifier rename plus two
call sites that were reaching into the now-removed private _adb method.
Test plan
Authored with Claude Code (Anthropic).
cc @cbilgin @psiddh