Skip to content

Qualcomm AI Engine Direct - add Windows-on-device execution support to Device (formerly SimpleADB) - #22795

Draft
chenweng-quic wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/chenweng/support_windows_in_python_script
Draft

chenweng-quic wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/chenweng/support_windows_in_python_script

Conversation

@chenweng-quic

@chenweng-quic chenweng-quic commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Device (renamed from SimpleADB) now dispatches to either ADB (existing Android/OE-Linux over-adb behavior, restored) or the new LocalBridge (Windows-on-Snapdragon, where the CLI runs on-device already, so file staging is a local copy and commands run through PowerShell instead of adb shell), selected automatically from --target.
  • SimpleADB -> Device rename is mechanical across all call sites; two call sites that reached into the now-removed private _adb were migrated to the existing public pull/pull_heap_output methods.
  • Updated READMEs / skill doc that referenced SimpleADB by name, and a couple of docstring lines that said "android device".
  • Review order: backends/qualcomm/export_utils.py has all the actual logic
    (DeviceBridge/ADB/LocalBridge, library naming per target, Device.init);
    everything else is the SimpleADB -> Device identifier rename plus two
    call sites that were reaching into the now-removed private _adb method.

Test plan

python "backends\qualcomm\tests\test_qnn_delegate.py" -k "test_qnn_backend_abs" `
>> --soc_model SM8850 `
>> --build_folder "build-arm64-windows" `
>> --target aarch64-windows-msvc
image

Authored with Claude Code (Anthropic).

cc @cbilgin @psiddh

@pytorch-bot

pytorch-bot Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22795

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 21 Awaiting Approval

As of commit 795e03c with merge base 91d26b3 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2026
@chenweng-quic chenweng-quic added module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/ and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 14, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2026
@chenweng-quic
chenweng-quic marked this pull request as ready for review September 15, 2026 01:49
@chenweng-quic
chenweng-quic marked this pull request as draft September 17, 2026 06:21
@chenweng-quic
chenweng-quic force-pushed the dev1/chenweng/support_windows_in_python_script branch from b386d2c to 7c77c2f Compare October 7, 2026 02:00
@chenweng-quic
chenweng-quic marked this pull request as ready for review October 7, 2026 02:00
@chenweng-quic
chenweng-quic marked this pull request as draft October 7, 2026 03:03
Add a DeviceBridge abstraction with ADB for Android and OE-Linux targets and WindowsBridge for local Windows-on-Snapdragon execution. Select the bridge from the configured target, stage Windows artifacts with local copies, run commands through PowerShell, and use target-specific runner and library names.

Rename SimpleADB to Device across Qualcomm scripts, tests, and documentation. Update profiling integrations to use the public Device push, execute, and pull APIs.

Co-authored with Codex (OpenAI).
@chenweng-quic
chenweng-quic force-pushed the dev1/chenweng/support_windows_in_python_script branch from 7c77c2f to 795e03c Compare October 7, 2026 03:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant