Skip to content

Add SupportedTensorDtypes::{BOOL,REALH} #9584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 25, 2025

The purpose of REALH will be to support the current use cases of unary_ufunc_realh. (Maybe we should just change them to support BF16?)

swolchok added 26 commits March 18, 2025 17:32
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok requested a review from GregoryComer as a code owner March 25, 2025 17:05
@@ -23,10 +23,14 @@ bool check_tensor_dtype(
return executorch::runtime::tensor_is_realhbbf16_type(t);
case SupportedTensorDtypes::REALHBF16:
return executorch::runtime::tensor_is_realhbf16_type(t);
case SupportedTensorDtypes::REALH:
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the h in realh? half?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it matches the naming scheme in

#define ET_SWITCH_REALH_TYPES(TYPE, CONTEXT, NAME, CTYPE_ALIAS, ...) \

@swolchok swolchok temporarily deployed to upload-benchmark-results March 25, 2025 17:22 — with GitHub Actions Inactive
@swolchok swolchok temporarily deployed to upload-benchmark-results March 25, 2025 17:26 — with GitHub Actions Inactive
@swolchok swolchok changed the base branch from gh/swolchok/386/head to gh/swolchok/382/head March 25, 2025 18:12
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

probably we want to skip adding REALH and just replace it with REALHBF16 in subseqeuent diffs

Base automatically changed from gh/swolchok/382/head to main April 22, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants