Update Executorch ops registration for rms_norm #9920
Merged
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Allows use of `aten::rms_norm` in place of `cadence::rms_norm` custom op, which is no longer needed. Differential Revision: D72485973
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9920
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 185f7b0 with merge base 5e9e9d1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72485973 |
ThomasJannaud
approved these changes
Apr 5, 2025
tarun292
approved these changes
Apr 7, 2025
|
@Vysarat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Summary: Allows use of `aten::rms_norm` in place of `cadence::rms_norm` custom op, which is no longer needed. Differential Revision: D72485973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Allows use of
aten::rms_normin place ofcadence::rms_normcustom op, which is no longer needed.Differential Revision: D72485973