Skip to content

[BugFix] Fix old pytorch dependencies #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vmoens merged 4 commits into from
Dec 30, 2025
Merged

[BugFix] Fix old pytorch dependencies #3266

vmoens merged 4 commits into from
Dec 30, 2025

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Dec 30, 2025 •
edited
Loading

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3266

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 13 New Failures, 1 Cancelled Job

As of commit 7bb436f with merge base 75de73d (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 30, 2025 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 164. Improved: $\large\color{#35bf28}24$. Worsened: $\large\color{#d91a1a}14$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 82.2804μs 81.4721μs 12.2741 KOps/s 11.9507 KOps/s $\color{#35bf28}+2.71\%$
test_tensor_to_bytestream_speed[torch.save] 0.1418ms 0.1414ms 7.0736 KOps/s 6.7601 KOps/s $\color{#35bf28}+4.64\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1195s 0.1189s 8.4093 Ops/s 7.4269 Ops/s $\textbf{\color{#35bf28}+13.23\%}$
test_tensor_to_bytestream_speed[numpy] 2.7858μs 2.7781μs 359.9566 KOps/s 340.8063 KOps/s $\textbf{\color{#35bf28}+5.62\%}$
test_tensor_to_bytestream_speed[safetensors] 37.3555μs 37.0286μs 27.0061 KOps/s 24.3484 KOps/s $\textbf{\color{#35bf28}+10.92\%}$
test_simple 0.5492s 0.5473s 1.8273 Ops/s 1.7275 Ops/s $\textbf{\color{#35bf28}+5.78\%}$
test_transformed 1.1298s 1.1285s 0.8861 Ops/s 0.8633 Ops/s $\color{#35bf28}+2.65\%$
test_serial 1.6501s 1.6461s 0.6075 Ops/s 0.5875 Ops/s $\color{#35bf28}+3.40\%$
test_parallel 1.2282s 1.2004s 0.8330 Ops/s 0.8956 Ops/s $\textbf{\color{#d91a1a}-6.99\%}$
test_step_mdp_speed[True-True-True-True-True] 0.2142ms 45.0175μs 22.2136 KOps/s 22.0577 KOps/s $\color{#35bf28}+0.71\%$
test_step_mdp_speed[True-True-True-True-False] 56.7310μs 25.1006μs 39.8397 KOps/s 39.4400 KOps/s $\color{#35bf28}+1.01\%$
test_step_mdp_speed[True-True-True-False-True] 68.1110μs 24.9691μs 40.0495 KOps/s 39.0290 KOps/s $\color{#35bf28}+2.61\%$
test_step_mdp_speed[True-True-True-False-False] 41.9700μs 13.8389μs 72.2599 KOps/s 71.9497 KOps/s $\color{#35bf28}+0.43\%$
test_step_mdp_speed[True-True-False-True-True] 77.3910μs 48.0935μs 20.7928 KOps/s 20.5667 KOps/s $\color{#35bf28}+1.10\%$
test_step_mdp_speed[True-True-False-True-False] 62.3300μs 28.0781μs 35.6150 KOps/s 34.1749 KOps/s $\color{#35bf28}+4.21\%$
test_step_mdp_speed[True-True-False-False-True] 72.7500μs 28.1713μs 35.4971 KOps/s 34.4141 KOps/s $\color{#35bf28}+3.15\%$
test_step_mdp_speed[True-True-False-False-False] 46.4400μs 16.6494μs 60.0623 KOps/s 59.0086 KOps/s $\color{#35bf28}+1.79\%$
test_step_mdp_speed[True-False-True-True-True] 91.5210μs 50.8489μs 19.6661 KOps/s 19.5137 KOps/s $\color{#35bf28}+0.78\%$
test_step_mdp_speed[True-False-True-True-False] 66.0300μs 30.7123μs 32.5602 KOps/s 31.5791 KOps/s $\color{#35bf28}+3.11\%$
test_step_mdp_speed[True-False-True-False-True] 74.5510μs 28.1931μs 35.4696 KOps/s 35.0019 KOps/s $\color{#35bf28}+1.34\%$
test_step_mdp_speed[True-False-True-False-False] 44.1610μs 16.5018μs 60.5993 KOps/s 59.0079 KOps/s $\color{#35bf28}+2.70\%$
test_step_mdp_speed[True-False-False-True-True] 0.1014ms 52.5586μs 19.0264 KOps/s 18.6957 KOps/s $\color{#35bf28}+1.77\%$
test_step_mdp_speed[True-False-False-True-False] 69.6410μs 32.8470μs 30.4442 KOps/s 29.4554 KOps/s $\color{#35bf28}+3.36\%$
test_step_mdp_speed[True-False-False-False-True] 83.7010μs 30.7754μs 32.4935 KOps/s 32.4522 KOps/s $\color{#35bf28}+0.13\%$
test_step_mdp_speed[True-False-False-False-False] 49.5710μs 19.3121μs 51.7810 KOps/s 50.8921 KOps/s $\color{#35bf28}+1.75\%$
test_step_mdp_speed[False-True-True-True-True] 86.9310μs 51.1686μs 19.5433 KOps/s 19.6015 KOps/s $\color{#d91a1a}-0.30\%$
test_step_mdp_speed[False-True-True-True-False] 88.0910μs 30.4291μs 32.8633 KOps/s 32.0021 KOps/s $\color{#35bf28}+2.69\%$
test_step_mdp_speed[False-True-True-False-True] 2.2861ms 32.0181μs 31.2323 KOps/s 30.6303 KOps/s $\color{#35bf28}+1.97\%$
test_step_mdp_speed[False-True-True-False-False] 49.2610μs 18.5395μs 53.9390 KOps/s 53.2778 KOps/s $\color{#35bf28}+1.24\%$
test_step_mdp_speed[False-True-False-True-True] 87.5210μs 53.4740μs 18.7007 KOps/s 18.5174 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[False-True-False-True-False] 66.0710μs 33.3937μs 29.9458 KOps/s 29.1257 KOps/s $\color{#35bf28}+2.82\%$
test_step_mdp_speed[False-True-False-False-True] 70.6410μs 34.9371μs 28.6229 KOps/s 29.0868 KOps/s $\color{#d91a1a}-1.59\%$
test_step_mdp_speed[False-True-False-False-False] 48.8310μs 21.0415μs 47.5251 KOps/s 46.8456 KOps/s $\color{#35bf28}+1.45\%$
test_step_mdp_speed[False-False-True-True-True] 99.1610μs 55.5608μs 17.9983 KOps/s 17.7090 KOps/s $\color{#35bf28}+1.63\%$
test_step_mdp_speed[False-False-True-True-False] 67.6810μs 36.2557μs 27.5819 KOps/s 27.2078 KOps/s $\color{#35bf28}+1.38\%$
test_step_mdp_speed[False-False-True-False-True] 66.3110μs 34.6026μs 28.8996 KOps/s 29.1635 KOps/s $\color{#d91a1a}-0.91\%$
test_step_mdp_speed[False-False-True-False-False] 51.5310μs 20.9794μs 47.6658 KOps/s 47.1923 KOps/s $\color{#35bf28}+1.00\%$
test_step_mdp_speed[False-False-False-True-True] 92.3410μs 58.5120μs 17.0905 KOps/s 17.0708 KOps/s $\color{#35bf28}+0.12\%$
test_step_mdp_speed[False-False-False-True-False] 68.9410μs 38.8295μs 25.7536 KOps/s 25.5754 KOps/s $\color{#35bf28}+0.70\%$
test_step_mdp_speed[False-False-False-False-True] 64.7510μs 37.0602μs 26.9831 KOps/s 27.7554 KOps/s $\color{#d91a1a}-2.78\%$
test_step_mdp_speed[False-False-False-False-False] 54.1200μs 23.8791μs 41.8776 KOps/s 42.2587 KOps/s $\color{#d91a1a}-0.90\%$
test_non_tensor_env_rollout_speed[1000-single-True] 0.8832s 0.7841s 1.2754 Ops/s 1.2721 Ops/s $\color{#35bf28}+0.26\%$
test_non_tensor_env_rollout_speed[1000-single-False] 0.7430s 0.6462s 1.5476 Ops/s 1.5511 Ops/s $\color{#d91a1a}-0.22\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-True] 1.7807s 1.7020s 0.5876 Ops/s 0.5851 Ops/s $\color{#35bf28}+0.42\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-False] 1.5518s 1.4743s 0.6783 Ops/s 0.6722 Ops/s $\color{#35bf28}+0.91\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-True] 2.0183s 1.9398s 0.5155 Ops/s 0.5120 Ops/s $\color{#35bf28}+0.68\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-False] 1.7911s 1.7108s 0.5845 Ops/s 0.5766 Ops/s $\color{#35bf28}+1.38\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-True] 4.8904s 4.6970s 0.2129 Ops/s 0.2117 Ops/s $\color{#35bf28}+0.56\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-False] 4.5569s 4.4811s 0.2232 Ops/s 0.2217 Ops/s $\color{#35bf28}+0.67\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-True] 2.0903s 1.9953s 0.5012 Ops/s 0.4884 Ops/s $\color{#35bf28}+2.61\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-False] 1.7622s 1.6813s 0.5948 Ops/s 0.5846 Ops/s $\color{#35bf28}+1.74\%$
test_values[generalized_advantage_estimate-True-True] 10.8569ms 9.9769ms 100.2313 Ops/s 96.0321 Ops/s $\color{#35bf28}+4.37\%$
test_values[vec_generalized_advantage_estimate-True-True] 20.6497ms 17.8702ms 55.9590 Ops/s 89.2005 Ops/s $\textbf{\color{#d91a1a}-37.27\%}$
test_values[td0_return_estimate-False-False] 0.1941ms 0.1287ms 7.7692 KOps/s 7.7523 KOps/s $\color{#35bf28}+0.22\%$
test_values[td1_return_estimate-False-False] 28.8243ms 27.8509ms 35.9054 Ops/s 35.5683 Ops/s $\color{#35bf28}+0.95\%$
test_values[vec_td1_return_estimate-False-False] 18.6055ms 17.7046ms 56.4826 Ops/s 89.3367 Ops/s $\textbf{\color{#d91a1a}-36.78\%}$
test_values[td_lambda_return_estimate-True-False] 39.6638ms 38.9946ms 25.6446 Ops/s 24.2140 Ops/s $\textbf{\color{#35bf28}+5.91\%}$
test_values[vec_td_lambda_return_estimate-True-False] 18.6196ms 17.6564ms 56.6366 Ops/s 87.9101 Ops/s $\textbf{\color{#d91a1a}-35.57\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.0369ms 8.7681ms 114.0501 Ops/s 108.1960 Ops/s $\textbf{\color{#35bf28}+5.41\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.9842ms 1.4957ms 668.5767 Ops/s 653.1338 Ops/s $\color{#35bf28}+2.36\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5123ms 0.4074ms 2.4548 KOps/s 2.4110 KOps/s $\color{#35bf28}+1.82\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 35.3677ms 34.4766ms 29.0052 Ops/s 38.7376 Ops/s $\textbf{\color{#d91a1a}-25.12\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 2.0090ms 1.8161ms 550.6295 Ops/s 576.8305 Ops/s $\color{#d91a1a}-4.54\%$
test_dqn_speed[False-None] 1.5080ms 1.3762ms 726.6315 Ops/s 706.1508 Ops/s $\color{#35bf28}+2.90\%$
test_dqn_speed[False-backward] 1.9564ms 1.8821ms 531.3097 Ops/s 523.0103 Ops/s $\color{#35bf28}+1.59\%$
test_dqn_speed[True-None] 0.6618ms 0.5250ms 1.9047 KOps/s 1.7247 KOps/s $\textbf{\color{#35bf28}+10.44\%}$
test_dqn_speed[True-backward] 1.0246ms 0.9656ms 1.0357 KOps/s 977.0655 Ops/s $\textbf{\color{#35bf28}+6.00\%}$
test_dqn_speed[reduce-overhead-None] 0.6014ms 0.5217ms 1.9169 KOps/s 1.8555 KOps/s $\color{#35bf28}+3.31\%$
test_dqn_speed[reduce-overhead-backward] 0.9940ms 0.9492ms 1.0536 KOps/s 1.0207 KOps/s $\color{#35bf28}+3.22\%$
test_ddpg_speed[False-None] 3.1513ms 2.8332ms 352.9527 Ops/s 350.8563 Ops/s $\color{#35bf28}+0.60\%$
test_ddpg_speed[False-backward] 4.0941ms 3.9833ms 251.0454 Ops/s 246.3314 Ops/s $\color{#35bf28}+1.91\%$
test_ddpg_speed[True-None] 1.5352ms 1.3743ms 727.6420 Ops/s 682.8266 Ops/s $\textbf{\color{#35bf28}+6.56\%}$
test_ddpg_speed[True-backward] 2.4107ms 2.3405ms 427.2541 Ops/s 343.9986 Ops/s $\textbf{\color{#35bf28}+24.20\%}$
test_ddpg_speed[reduce-overhead-None] 1.4879ms 1.3635ms 733.3876 Ops/s 715.7852 Ops/s $\color{#35bf28}+2.46\%$
test_ddpg_speed[reduce-overhead-backward] 2.4094ms 2.3449ms 426.4516 Ops/s 414.1880 Ops/s $\color{#35bf28}+2.96\%$
test_sac_speed[False-None] 8.2767ms 7.8690ms 127.0817 Ops/s 125.1324 Ops/s $\color{#35bf28}+1.56\%$
test_sac_speed[False-backward] 11.1177ms 10.9297ms 91.4939 Ops/s 88.7470 Ops/s $\color{#35bf28}+3.10\%$
test_sac_speed[True-None] 2.2399ms 2.1241ms 470.7924 Ops/s 454.2910 Ops/s $\color{#35bf28}+3.63\%$
test_sac_speed[True-backward] 4.1279ms 3.9933ms 250.4208 Ops/s 233.5551 Ops/s $\textbf{\color{#35bf28}+7.22\%}$
test_sac_speed[reduce-overhead-None] 2.6512ms 2.1342ms 468.5579 Ops/s 442.4435 Ops/s $\textbf{\color{#35bf28}+5.90\%}$
test_sac_speed[reduce-overhead-backward] 4.1031ms 3.9824ms 251.1060 Ops/s 247.7129 Ops/s $\color{#35bf28}+1.37\%$
test_redq_speed[False-None] 13.2926ms 10.3275ms 96.8292 Ops/s 96.0949 Ops/s $\color{#35bf28}+0.76\%$
test_redq_speed[False-backward] 23.4451ms 18.0363ms 55.4439 Ops/s 56.7700 Ops/s $\color{#d91a1a}-2.34\%$
test_redq_speed[True-None] 4.7045ms 4.4702ms 223.7046 Ops/s 219.5088 Ops/s $\color{#35bf28}+1.91\%$
test_redq_speed[True-backward] 10.2748ms 9.8811ms 101.2032 Ops/s 101.5190 Ops/s $\color{#d91a1a}-0.31\%$
test_redq_speed[reduce-overhead-None] 4.6935ms 4.4124ms 226.6343 Ops/s 219.5834 Ops/s $\color{#35bf28}+3.21\%$
test_redq_speed[reduce-overhead-backward] 10.6198ms 10.1207ms 98.8074 Ops/s 95.0104 Ops/s $\color{#35bf28}+4.00\%$
test_redq_deprec_speed[False-None] 16.6208ms 11.4121ms 87.6264 Ops/s 89.6930 Ops/s $\color{#d91a1a}-2.30\%$
test_redq_deprec_speed[False-backward] 16.3461ms 15.8464ms 63.1057 Ops/s 62.9537 Ops/s $\color{#35bf28}+0.24\%$
test_redq_deprec_speed[True-None] 4.0328ms 3.7123ms 269.3755 Ops/s 259.7355 Ops/s $\color{#35bf28}+3.71\%$
test_redq_deprec_speed[True-backward] 7.9271ms 7.6668ms 130.4330 Ops/s 125.6771 Ops/s $\color{#35bf28}+3.78\%$
test_redq_deprec_speed[reduce-overhead-None] 3.9282ms 3.6401ms 274.7159 Ops/s 262.6260 Ops/s $\color{#35bf28}+4.60\%$
test_redq_deprec_speed[reduce-overhead-backward] 8.0530ms 7.6608ms 130.5348 Ops/s 127.2342 Ops/s $\color{#35bf28}+2.59\%$
test_td3_speed[False-None] 8.0302ms 7.8713ms 127.0433 Ops/s 124.9332 Ops/s $\color{#35bf28}+1.69\%$
test_td3_speed[False-backward] 10.9853ms 10.6185ms 94.1749 Ops/s 92.4421 Ops/s $\color{#35bf28}+1.87\%$
test_td3_speed[True-None] 1.9063ms 1.8013ms 555.1490 Ops/s 548.3325 Ops/s $\color{#35bf28}+1.24\%$
test_td3_speed[True-backward] 3.7906ms 3.6402ms 274.7073 Ops/s 262.9934 Ops/s $\color{#35bf28}+4.45\%$
test_td3_speed[reduce-overhead-None] 1.8395ms 1.7973ms 556.3809 Ops/s 553.0192 Ops/s $\color{#35bf28}+0.61\%$
test_td3_speed[reduce-overhead-backward] 3.7917ms 3.6860ms 271.2946 Ops/s 220.9842 Ops/s $\textbf{\color{#35bf28}+22.77\%}$
test_cql_speed[False-None] 26.5613ms 25.8489ms 38.6863 Ops/s 38.1610 Ops/s $\color{#35bf28}+1.38\%$
test_cql_speed[False-backward] 39.5927ms 35.4636ms 28.1980 Ops/s 28.2312 Ops/s $\color{#d91a1a}-0.12\%$
test_cql_speed[True-None] 12.7774ms 12.4300ms 80.4508 Ops/s 79.8413 Ops/s $\color{#35bf28}+0.76\%$
test_cql_speed[True-backward] 18.7120ms 18.3305ms 54.5540 Ops/s 51.3939 Ops/s $\textbf{\color{#35bf28}+6.15\%}$
test_cql_speed[reduce-overhead-None] 12.8520ms 12.4760ms 80.1537 Ops/s 80.3231 Ops/s $\color{#d91a1a}-0.21\%$
test_cql_speed[reduce-overhead-backward] 19.0828ms 18.4734ms 54.1319 Ops/s 55.4572 Ops/s $\color{#d91a1a}-2.39\%$
test_a2c_speed[False-None] 5.7720ms 5.4344ms 184.0121 Ops/s 178.3689 Ops/s $\color{#35bf28}+3.16\%$
test_a2c_speed[False-backward] 12.3257ms 11.9016ms 84.0220 Ops/s 82.8931 Ops/s $\color{#35bf28}+1.36\%$
test_a2c_speed[True-None] 5.2394ms 3.7555ms 266.2787 Ops/s 265.3378 Ops/s $\color{#35bf28}+0.35\%$
test_a2c_speed[True-backward] 8.8597ms 8.6205ms 116.0027 Ops/s 109.3578 Ops/s $\textbf{\color{#35bf28}+6.08\%}$
test_a2c_speed[reduce-overhead-None] 3.8729ms 3.7093ms 269.5931 Ops/s 265.1853 Ops/s $\color{#35bf28}+1.66\%$
test_a2c_speed[reduce-overhead-backward] 10.0185ms 9.0597ms 110.3792 Ops/s 111.9728 Ops/s $\color{#d91a1a}-1.42\%$
test_ppo_speed[False-None] 6.0638ms 5.8288ms 171.5621 Ops/s 168.0962 Ops/s $\color{#35bf28}+2.06\%$
test_ppo_speed[False-backward] 12.7334ms 12.3845ms 80.7458 Ops/s 79.6843 Ops/s $\color{#35bf28}+1.33\%$
test_ppo_speed[True-None] 3.8083ms 3.6053ms 277.3713 Ops/s 274.6947 Ops/s $\color{#35bf28}+0.97\%$
test_ppo_speed[True-backward] 8.8005ms 8.4705ms 118.0566 Ops/s 117.5297 Ops/s $\color{#35bf28}+0.45\%$
test_ppo_speed[reduce-overhead-None] 3.7629ms 3.5943ms 278.2145 Ops/s 275.4613 Ops/s $\color{#35bf28}+1.00\%$
test_ppo_speed[reduce-overhead-backward] 8.9659ms 8.7316ms 114.5271 Ops/s 110.9893 Ops/s $\color{#35bf28}+3.19\%$
test_reinforce_speed[False-None] 4.7623ms 4.5324ms 220.6345 Ops/s 214.7332 Ops/s $\color{#35bf28}+2.75\%$
test_reinforce_speed[False-backward] 7.6973ms 7.3893ms 135.3308 Ops/s 132.9904 Ops/s $\color{#35bf28}+1.76\%$
test_reinforce_speed[True-None] 3.0728ms 2.9112ms 343.4982 Ops/s 329.8197 Ops/s $\color{#35bf28}+4.15\%$
test_reinforce_speed[True-backward] 8.0095ms 7.7293ms 129.3780 Ops/s 119.0196 Ops/s $\textbf{\color{#35bf28}+8.70\%}$
test_reinforce_speed[reduce-overhead-None] 3.0299ms 2.8631ms 349.2755 Ops/s 340.9756 Ops/s $\color{#35bf28}+2.43\%$
test_reinforce_speed[reduce-overhead-backward] 8.2008ms 7.9525ms 125.7468 Ops/s 124.3774 Ops/s $\color{#35bf28}+1.10\%$
test_iql_speed[False-None] 22.8868ms 19.9003ms 50.2506 Ops/s 49.1497 Ops/s $\color{#35bf28}+2.24\%$
test_iql_speed[False-backward] 30.8169ms 30.2436ms 33.0648 Ops/s 32.7319 Ops/s $\color{#35bf28}+1.02\%$
test_iql_speed[True-None] 8.9569ms 8.5520ms 116.9315 Ops/s 113.4354 Ops/s $\color{#35bf28}+3.08\%$
test_iql_speed[True-backward] 17.8774ms 16.8537ms 59.3342 Ops/s 57.8148 Ops/s $\color{#35bf28}+2.63\%$
test_iql_speed[reduce-overhead-None] 8.9364ms 8.5940ms 116.3608 Ops/s 114.1345 Ops/s $\color{#35bf28}+1.95\%$
test_iql_speed[reduce-overhead-backward] 17.8649ms 17.3559ms 57.6172 Ops/s 57.8159 Ops/s $\color{#d91a1a}-0.34\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 8.0240ms 6.1267ms 163.2195 Ops/s 164.0916 Ops/s $\color{#d91a1a}-0.53\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6417ms 0.3113ms 3.2126 KOps/s 3.0857 KOps/s $\color{#35bf28}+4.11\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6936ms 0.3125ms 3.1998 KOps/s 3.2019 KOps/s $\color{#d91a1a}-0.07\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.2394ms 5.8403ms 171.2243 Ops/s 171.2993 Ops/s $\color{#d91a1a}-0.04\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0293ms 0.2926ms 3.4179 KOps/s 3.0561 KOps/s $\textbf{\color{#35bf28}+11.84\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5345ms 0.2671ms 3.7437 KOps/s 3.5496 KOps/s $\textbf{\color{#35bf28}+5.47\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4950ms 1.2456ms 802.8464 Ops/s 722.3024 Ops/s $\textbf{\color{#35bf28}+11.15\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.3960ms 1.1640ms 859.1161 Ops/s 779.0505 Ops/s $\textbf{\color{#35bf28}+10.28\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 10.2853ms 6.1857ms 161.6645 Ops/s 166.4480 Ops/s $\color{#d91a1a}-2.87\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.1266ms 0.5081ms 1.9680 KOps/s 2.0294 KOps/s $\color{#d91a1a}-3.03\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7600ms 0.4593ms 2.1773 KOps/s 2.3618 KOps/s $\textbf{\color{#d91a1a}-7.81\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.9848ms 5.8471ms 171.0256 Ops/s 171.5929 Ops/s $\color{#d91a1a}-0.33\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.9307ms 0.3340ms 2.9940 KOps/s 2.5116 KOps/s $\textbf{\color{#35bf28}+19.20\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5945ms 0.3704ms 2.6996 KOps/s 3.6884 KOps/s $\textbf{\color{#d91a1a}-26.81\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1187ms 5.7553ms 173.7529 Ops/s 172.4359 Ops/s $\color{#35bf28}+0.76\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.1627ms 0.4153ms 2.4077 KOps/s 681.0544 Ops/s $\textbf{\color{#35bf28}+253.53\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6156ms 0.3926ms 2.5473 KOps/s 3.7495 KOps/s $\textbf{\color{#d91a1a}-32.06\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.0520ms 5.9467ms 168.1617 Ops/s 164.7681 Ops/s $\color{#35bf28}+2.06\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.0778ms 0.5151ms 1.9414 KOps/s 2.1708 KOps/s $\textbf{\color{#d91a1a}-10.57\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7369ms 0.5005ms 1.9981 KOps/s 2.3203 KOps/s $\textbf{\color{#d91a1a}-13.89\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.3225ms 4.9315ms 202.7791 Ops/s 196.3060 Ops/s $\color{#35bf28}+3.30\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 9.5773ms 2.3468ms 426.1146 Ops/s 476.2869 Ops/s $\textbf{\color{#d91a1a}-10.53\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 3.3013ms 1.1244ms 889.3685 Ops/s 824.1455 Ops/s $\textbf{\color{#35bf28}+7.91\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 9.0857ms 5.0867ms 196.5916 Ops/s 196.5496 Ops/s $\color{#35bf28}+0.02\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 6.5710ms 2.4123ms 414.5500 Ops/s 479.0283 Ops/s $\textbf{\color{#d91a1a}-13.46\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 8.9540ms 1.3164ms 759.6459 Ops/s 808.9912 Ops/s $\textbf{\color{#d91a1a}-6.10\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.6145s 17.4792ms 57.2109 Ops/s 53.1837 Ops/s $\textbf{\color{#35bf28}+7.57\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 9.2276ms 2.1744ms 459.9041 Ops/s 460.4907 Ops/s $\color{#d91a1a}-0.13\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 8.2912ms 1.3592ms 735.7343 Ops/s 974.2645 Ops/s $\textbf{\color{#d91a1a}-24.48\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 36.2696ms 34.4244ms 29.0492 Ops/s 28.4866 Ops/s $\color{#35bf28}+1.97\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.2633ms 17.5726ms 56.9069 Ops/s 56.5499 Ops/s $\color{#35bf28}+0.63\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 37.4226ms 35.2502ms 28.3686 Ops/s 27.4489 Ops/s $\color{#35bf28}+3.35\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.6412ms 17.7932ms 56.2012 Ops/s 54.9867 Ops/s $\color{#35bf28}+2.21\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 38.8946ms 37.2031ms 26.8795 Ops/s 25.7110 Ops/s $\color{#35bf28}+4.54\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 20.3202ms 19.1339ms 52.2634 Ops/s 51.0816 Ops/s $\color{#35bf28}+2.31\%$

@vmoens
Copy link
Collaborator Author

vmoens commented Dec 30, 2025

@cmdout I reverted #3236 because it was breaking things. Could you explain further why that was needed? Happy to chat about this with you!

@vmoens vmoens added the bug Something isn't working label Dec 30, 2025
@vmoens vmoens merged commit eb2aaeb into main Dec 30, 2025
95 of 109 checks passed
@vmoens vmoens deleted the fix-olddeps-2.2 branch December 30, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens