Skip to content

[BugFix] Multiple fixes in CI and flaky features #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vmoens wants to merge 1 commit into from
Closed

[BugFix] Multiple fixes in CI and flaky features #3267

vmoens wants to merge 1 commit into from

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Dec 30, 2025

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 30, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3267

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 12 New Failures, 2 Cancelled Jobs, 4 Pending

As of commit 405d1d3 with merge base eb2aaeb (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 30, 2025

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 164. Improved: $\large\color{#35bf28}23$. Worsened: $\large\color{#d91a1a}8$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 82.5085μs 81.2574μs 12.3066 KOps/s 11.4576 KOps/s $\textbf{\color{#35bf28}+7.41\%}$
test_tensor_to_bytestream_speed[torch.save] 0.1412ms 0.1407ms 7.1057 KOps/s 6.9932 KOps/s $\color{#35bf28}+1.61\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1255s 0.1253s 7.9835 Ops/s 7.7951 Ops/s $\color{#35bf28}+2.42\%$
test_tensor_to_bytestream_speed[numpy] 2.7159μs 2.7078μs 369.3095 KOps/s 369.3523 KOps/s $\color{#d91a1a}-0.01\%$
test_tensor_to_bytestream_speed[safetensors] 39.4221μs 38.7264μs 25.8222 KOps/s 24.6828 KOps/s $\color{#35bf28}+4.62\%$
test_simple 0.5585s 0.5577s 1.7931 Ops/s 1.7258 Ops/s $\color{#35bf28}+3.90\%$
test_transformed 1.1410s 1.1390s 0.8779 Ops/s 0.8632 Ops/s $\color{#35bf28}+1.71\%$
test_serial 1.6898s 1.6876s 0.5926 Ops/s 0.5857 Ops/s $\color{#35bf28}+1.17\%$
test_parallel 1.2170s 1.1730s 0.8525 Ops/s 0.8609 Ops/s $\color{#d91a1a}-0.97\%$
test_step_mdp_speed[True-True-True-True-True] 0.3391ms 48.3061μs 20.7013 KOps/s 22.2584 KOps/s $\textbf{\color{#d91a1a}-7.00\%}$
test_step_mdp_speed[True-True-True-True-False] 60.2310μs 26.3625μs 37.9327 KOps/s 39.4934 KOps/s $\color{#d91a1a}-3.95\%$
test_step_mdp_speed[True-True-True-False-True] 64.3810μs 26.7877μs 37.3305 KOps/s 39.4715 KOps/s $\textbf{\color{#d91a1a}-5.42\%}$
test_step_mdp_speed[True-True-True-False-False] 59.1510μs 15.0476μs 66.4556 KOps/s 71.5676 KOps/s $\textbf{\color{#d91a1a}-7.14\%}$
test_step_mdp_speed[True-True-False-True-True] 87.9120μs 51.3205μs 19.4854 KOps/s 20.4470 KOps/s $\color{#d91a1a}-4.70\%$
test_step_mdp_speed[True-True-False-True-False] 62.6210μs 28.4409μs 35.1606 KOps/s 35.1695 KOps/s $\color{#d91a1a}-0.03\%$
test_step_mdp_speed[True-True-False-False-True] 65.4710μs 30.5168μs 32.7688 KOps/s 34.7839 KOps/s $\textbf{\color{#d91a1a}-5.79\%}$
test_step_mdp_speed[True-True-False-False-False] 51.3010μs 17.8854μs 55.9115 KOps/s 58.5113 KOps/s $\color{#d91a1a}-4.44\%$
test_step_mdp_speed[True-False-True-True-True] 88.5410μs 52.8006μs 18.9392 KOps/s 19.3605 KOps/s $\color{#d91a1a}-2.18\%$
test_step_mdp_speed[True-False-True-True-False] 68.0420μs 31.2699μs 31.9797 KOps/s 31.7323 KOps/s $\color{#35bf28}+0.78\%$
test_step_mdp_speed[True-False-True-False-True] 66.9120μs 29.8660μs 33.4829 KOps/s 35.2333 KOps/s $\color{#d91a1a}-4.97\%$
test_step_mdp_speed[True-False-True-False-False] 47.7910μs 16.8486μs 59.3521 KOps/s 58.9985 KOps/s $\color{#35bf28}+0.60\%$
test_step_mdp_speed[True-False-False-True-True] 97.2120μs 55.3586μs 18.0640 KOps/s 18.7660 KOps/s $\color{#d91a1a}-3.74\%$
test_step_mdp_speed[True-False-False-True-False] 67.2610μs 34.0501μs 29.3685 KOps/s 29.6848 KOps/s $\color{#d91a1a}-1.07\%$
test_step_mdp_speed[True-False-False-False-True] 67.2920μs 31.2602μs 31.9896 KOps/s 32.0450 KOps/s $\color{#d91a1a}-0.17\%$
test_step_mdp_speed[True-False-False-False-False] 49.8410μs 19.3771μs 51.6074 KOps/s 50.8860 KOps/s $\color{#35bf28}+1.42\%$
test_step_mdp_speed[False-True-True-True-True] 99.5120μs 53.5406μs 18.6774 KOps/s 19.5085 KOps/s $\color{#d91a1a}-4.26\%$
test_step_mdp_speed[False-True-True-True-False] 71.4010μs 30.4389μs 32.8527 KOps/s 32.0204 KOps/s $\color{#35bf28}+2.60\%$
test_step_mdp_speed[False-True-True-False-True] 2.4361ms 33.4420μs 29.9025 KOps/s 30.0961 KOps/s $\color{#d91a1a}-0.64\%$
test_step_mdp_speed[False-True-True-False-False] 52.5410μs 19.4255μs 51.4788 KOps/s 55.1111 KOps/s $\textbf{\color{#d91a1a}-6.59\%}$
test_step_mdp_speed[False-True-False-True-True] 0.1006ms 56.2816μs 17.7678 KOps/s 18.1405 KOps/s $\color{#d91a1a}-2.05\%$
test_step_mdp_speed[False-True-False-True-False] 76.7820μs 33.6106μs 29.7525 KOps/s 29.3150 KOps/s $\color{#35bf28}+1.49\%$
test_step_mdp_speed[False-True-False-False-True] 72.8420μs 34.7843μs 28.7486 KOps/s 28.5684 KOps/s $\color{#35bf28}+0.63\%$
test_step_mdp_speed[False-True-False-False-False] 65.3010μs 21.8336μs 45.8010 KOps/s 46.2728 KOps/s $\color{#d91a1a}-1.02\%$
test_step_mdp_speed[False-False-True-True-True] 96.1020μs 58.2083μs 17.1797 KOps/s 16.9994 KOps/s $\color{#35bf28}+1.06\%$
test_step_mdp_speed[False-False-True-True-False] 70.4120μs 36.1707μs 27.6467 KOps/s 27.0409 KOps/s $\color{#35bf28}+2.24\%$
test_step_mdp_speed[False-False-True-False-True] 86.1720μs 34.5466μs 28.9464 KOps/s 28.8600 KOps/s $\color{#35bf28}+0.30\%$
test_step_mdp_speed[False-False-True-False-False] 50.8610μs 21.4126μs 46.7015 KOps/s 47.9677 KOps/s $\color{#d91a1a}-2.64\%$
test_step_mdp_speed[False-False-False-True-True] 95.7420μs 59.1688μs 16.9008 KOps/s 17.2124 KOps/s $\color{#d91a1a}-1.81\%$
test_step_mdp_speed[False-False-False-True-False] 0.1093ms 38.9409μs 25.6799 KOps/s 25.6484 KOps/s $\color{#35bf28}+0.12\%$
test_step_mdp_speed[False-False-False-False-True] 81.1020μs 37.5828μs 26.6079 KOps/s 26.9625 KOps/s $\color{#d91a1a}-1.32\%$
test_step_mdp_speed[False-False-False-False-False] 52.8010μs 23.7419μs 42.1196 KOps/s 41.8838 KOps/s $\color{#35bf28}+0.56\%$
test_non_tensor_env_rollout_speed[1000-single-True] 0.8918s 0.7954s 1.2573 Ops/s 1.2504 Ops/s $\color{#35bf28}+0.55\%$
test_non_tensor_env_rollout_speed[1000-single-False] 0.7476s 0.6598s 1.5156 Ops/s 1.5046 Ops/s $\color{#35bf28}+0.73\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-True] 1.8231s 1.7280s 0.5787 Ops/s 0.5702 Ops/s $\color{#35bf28}+1.49\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-False] 1.5773s 1.4987s 0.6672 Ops/s 0.6567 Ops/s $\color{#35bf28}+1.60\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-True] 2.0360s 1.9554s 0.5114 Ops/s 0.4983 Ops/s $\color{#35bf28}+2.63\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-False] 1.8926s 1.8067s 0.5535 Ops/s 0.5667 Ops/s $\color{#d91a1a}-2.33\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-True] 4.8032s 4.6753s 0.2139 Ops/s 0.2123 Ops/s $\color{#35bf28}+0.77\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-False] 4.6139s 4.5058s 0.2219 Ops/s 0.2222 Ops/s $\color{#d91a1a}-0.12\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-True] 2.0555s 2.0043s 0.4989 Ops/s 0.5002 Ops/s $\color{#d91a1a}-0.25\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-False] 1.7917s 1.7173s 0.5823 Ops/s 0.5917 Ops/s $\color{#d91a1a}-1.59\%$
test_values[generalized_advantage_estimate-True-True] 10.4615ms 10.3238ms 96.8636 Ops/s 93.8450 Ops/s $\color{#35bf28}+3.22\%$
test_values[vec_generalized_advantage_estimate-True-True] 22.9197ms 18.6730ms 53.5532 Ops/s 54.8306 Ops/s $\color{#d91a1a}-2.33\%$
test_values[td0_return_estimate-False-False] 0.2292ms 0.1267ms 7.8917 KOps/s 4.8607 KOps/s $\textbf{\color{#35bf28}+62.36\%}$
test_values[td1_return_estimate-False-False] 28.1297ms 27.7647ms 36.0169 Ops/s 35.2820 Ops/s $\color{#35bf28}+2.08\%$
test_values[vec_td1_return_estimate-False-False] 18.8575ms 17.9157ms 55.8168 Ops/s 55.8807 Ops/s $\color{#d91a1a}-0.11\%$
test_values[td_lambda_return_estimate-True-False] 41.7838ms 41.2047ms 24.2691 Ops/s 24.3495 Ops/s $\color{#d91a1a}-0.33\%$
test_values[vec_td_lambda_return_estimate-True-False] 19.0610ms 17.8164ms 56.1280 Ops/s 56.0989 Ops/s $\color{#35bf28}+0.05\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.3851ms 9.3014ms 107.5101 Ops/s 104.2113 Ops/s $\color{#35bf28}+3.17\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.7262ms 1.5498ms 645.2375 Ops/s 651.8060 Ops/s $\color{#d91a1a}-1.01\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4704ms 0.4198ms 2.3821 KOps/s 2.3482 KOps/s $\color{#35bf28}+1.44\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 35.2754ms 34.7412ms 28.7842 Ops/s 27.4199 Ops/s $\color{#35bf28}+4.98\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 1.9576ms 1.7782ms 562.3577 Ops/s 557.2849 Ops/s $\color{#35bf28}+0.91\%$
test_dqn_speed[False-None] 1.5878ms 1.4154ms 706.5198 Ops/s 707.3439 Ops/s $\color{#d91a1a}-0.12\%$
test_dqn_speed[False-backward] 2.0313ms 1.9401ms 515.4445 Ops/s 517.6441 Ops/s $\color{#d91a1a}-0.42\%$
test_dqn_speed[True-None] 0.7168ms 0.5519ms 1.8119 KOps/s 1.8064 KOps/s $\color{#35bf28}+0.30\%$
test_dqn_speed[True-backward] 1.0429ms 0.9835ms 1.0168 KOps/s 847.2122 Ops/s $\textbf{\color{#35bf28}+20.01\%}$
test_dqn_speed[reduce-overhead-None] 0.6054ms 0.5382ms 1.8582 KOps/s 1.8080 KOps/s $\color{#35bf28}+2.77\%$
test_dqn_speed[reduce-overhead-backward] 1.0297ms 0.9947ms 1.0054 KOps/s 1.0243 KOps/s $\color{#d91a1a}-1.85\%$
test_ddpg_speed[False-None] 3.1566ms 2.9013ms 344.6690 Ops/s 346.1624 Ops/s $\color{#d91a1a}-0.43\%$
test_ddpg_speed[False-backward] 4.5289ms 4.1359ms 241.7863 Ops/s 241.1835 Ops/s $\color{#35bf28}+0.25\%$
test_ddpg_speed[True-None] 1.4816ms 1.3861ms 721.4381 Ops/s 715.9417 Ops/s $\color{#35bf28}+0.77\%$
test_ddpg_speed[True-backward] 2.4086ms 2.3670ms 422.4825 Ops/s 418.4867 Ops/s $\color{#35bf28}+0.95\%$
test_ddpg_speed[reduce-overhead-None] 1.5242ms 1.3794ms 724.9688 Ops/s 710.6720 Ops/s $\color{#35bf28}+2.01\%$
test_ddpg_speed[reduce-overhead-backward] 2.4123ms 2.3553ms 424.5722 Ops/s 422.6679 Ops/s $\color{#35bf28}+0.45\%$
test_sac_speed[False-None] 8.4092ms 7.9690ms 125.4862 Ops/s 124.0809 Ops/s $\color{#35bf28}+1.13\%$
test_sac_speed[False-backward] 11.6211ms 11.2414ms 88.9571 Ops/s 88.0755 Ops/s $\color{#35bf28}+1.00\%$
test_sac_speed[True-None] 2.3147ms 2.1318ms 469.0917 Ops/s 455.7248 Ops/s $\color{#35bf28}+2.93\%$
test_sac_speed[True-backward] 4.2256ms 4.0732ms 245.5076 Ops/s 220.4929 Ops/s $\textbf{\color{#35bf28}+11.34\%}$
test_sac_speed[reduce-overhead-None] 2.2643ms 2.1256ms 470.4584 Ops/s 455.8599 Ops/s $\color{#35bf28}+3.20\%$
test_sac_speed[reduce-overhead-backward] 4.1299ms 4.0278ms 248.2743 Ops/s 232.2995 Ops/s $\textbf{\color{#35bf28}+6.88\%}$
test_redq_speed[False-None] 15.1524ms 10.7948ms 92.6375 Ops/s 90.2496 Ops/s $\color{#35bf28}+2.65\%$
test_redq_speed[False-backward] 20.3573ms 18.2108ms 54.9125 Ops/s 54.7328 Ops/s $\color{#35bf28}+0.33\%$
test_redq_speed[True-None] 6.0319ms 4.3961ms 227.4754 Ops/s 223.5371 Ops/s $\color{#35bf28}+1.76\%$
test_redq_speed[True-backward] 9.9778ms 9.4757ms 105.5326 Ops/s 105.5250 Ops/s $+0.01\%$
test_redq_speed[reduce-overhead-None] 5.9735ms 4.6073ms 217.0463 Ops/s 217.6418 Ops/s $\color{#d91a1a}-0.27\%$
test_redq_speed[reduce-overhead-backward] 11.0129ms 9.8614ms 101.4055 Ops/s 98.2278 Ops/s $\color{#35bf28}+3.24\%$
test_redq_deprec_speed[False-None] 12.0578ms 11.3423ms 88.1658 Ops/s 87.5679 Ops/s $\color{#35bf28}+0.68\%$
test_redq_deprec_speed[False-backward] 16.7140ms 16.1258ms 62.0125 Ops/s 60.9510 Ops/s $\color{#35bf28}+1.74\%$
test_redq_deprec_speed[True-None] 4.1554ms 3.7464ms 266.9236 Ops/s 255.4019 Ops/s $\color{#35bf28}+4.51\%$
test_redq_deprec_speed[True-backward] 8.0130ms 7.7060ms 129.7689 Ops/s 126.2762 Ops/s $\color{#35bf28}+2.77\%$
test_redq_deprec_speed[reduce-overhead-None] 4.2874ms 3.7188ms 268.9060 Ops/s 273.6066 Ops/s $\color{#d91a1a}-1.72\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.9091ms 7.7557ms 128.9368 Ops/s 128.6922 Ops/s $\color{#35bf28}+0.19\%$
test_td3_speed[False-None] 8.3655ms 8.1415ms 122.8276 Ops/s 122.6978 Ops/s $\color{#35bf28}+0.11\%$
test_td3_speed[False-backward] 11.4192ms 11.0162ms 90.7757 Ops/s 90.8082 Ops/s $\color{#d91a1a}-0.04\%$
test_td3_speed[True-None] 1.8712ms 1.8221ms 548.8308 Ops/s 534.2832 Ops/s $\color{#35bf28}+2.72\%$
test_td3_speed[True-backward] 3.6620ms 3.5490ms 281.7728 Ops/s 276.6645 Ops/s $\color{#35bf28}+1.85\%$
test_td3_speed[reduce-overhead-None] 1.8535ms 1.8001ms 555.5160 Ops/s 554.5864 Ops/s $\color{#35bf28}+0.17\%$
test_td3_speed[reduce-overhead-backward] 3.6991ms 3.5853ms 278.9140 Ops/s 269.9324 Ops/s $\color{#35bf28}+3.33\%$
test_cql_speed[False-None] 29.8942ms 26.1199ms 38.2850 Ops/s 37.5050 Ops/s $\color{#35bf28}+2.08\%$
test_cql_speed[False-backward] 38.4051ms 35.4424ms 28.2148 Ops/s 28.0563 Ops/s $\color{#35bf28}+0.56\%$
test_cql_speed[True-None] 12.9082ms 12.2723ms 81.4840 Ops/s 77.8609 Ops/s $\color{#35bf28}+4.65\%$
test_cql_speed[True-backward] 18.5318ms 17.8635ms 55.9800 Ops/s 55.1131 Ops/s $\color{#35bf28}+1.57\%$
test_cql_speed[reduce-overhead-None] 13.0758ms 12.4473ms 80.3384 Ops/s 80.2011 Ops/s $\color{#35bf28}+0.17\%$
test_cql_speed[reduce-overhead-backward] 18.6327ms 18.1625ms 55.0585 Ops/s 55.2931 Ops/s $\color{#d91a1a}-0.42\%$
test_a2c_speed[False-None] 5.7901ms 5.4607ms 183.1266 Ops/s 180.8301 Ops/s $\color{#35bf28}+1.27\%$
test_a2c_speed[False-backward] 12.4868ms 12.0157ms 83.2243 Ops/s 83.4609 Ops/s $\color{#d91a1a}-0.28\%$
test_a2c_speed[True-None] 3.9305ms 3.6730ms 272.2568 Ops/s 259.6169 Ops/s $\color{#35bf28}+4.87\%$
test_a2c_speed[True-backward] 8.8082ms 8.5124ms 117.4759 Ops/s 115.6704 Ops/s $\color{#35bf28}+1.56\%$
test_a2c_speed[reduce-overhead-None] 4.1579ms 3.6950ms 270.6345 Ops/s 268.6506 Ops/s $\color{#35bf28}+0.74\%$
test_a2c_speed[reduce-overhead-backward] 8.8558ms 8.6316ms 115.8540 Ops/s 112.9283 Ops/s $\color{#35bf28}+2.59\%$
test_ppo_speed[False-None] 6.3866ms 5.8849ms 169.9274 Ops/s 165.9093 Ops/s $\color{#35bf28}+2.42\%$
test_ppo_speed[False-backward] 12.8367ms 12.5605ms 79.6147 Ops/s 77.9651 Ops/s $\color{#35bf28}+2.12\%$
test_ppo_speed[True-None] 4.1417ms 3.6061ms 277.3105 Ops/s 271.4710 Ops/s $\color{#35bf28}+2.15\%$
test_ppo_speed[True-backward] 8.6063ms 8.3532ms 119.7139 Ops/s 116.0300 Ops/s $\color{#35bf28}+3.17\%$
test_ppo_speed[reduce-overhead-None] 4.1017ms 3.5792ms 279.3907 Ops/s 274.8924 Ops/s $\color{#35bf28}+1.64\%$
test_ppo_speed[reduce-overhead-backward] 9.0917ms 8.6310ms 115.8611 Ops/s 113.8576 Ops/s $\color{#35bf28}+1.76\%$
test_reinforce_speed[False-None] 5.0242ms 4.5556ms 219.5121 Ops/s 216.9682 Ops/s $\color{#35bf28}+1.17\%$
test_reinforce_speed[False-backward] 7.6882ms 7.4524ms 134.1843 Ops/s 132.8111 Ops/s $\color{#35bf28}+1.03\%$
test_reinforce_speed[True-None] 3.3182ms 2.8345ms 352.7935 Ops/s 341.6889 Ops/s $\color{#35bf28}+3.25\%$
test_reinforce_speed[True-backward] 7.9078ms 7.6301ms 131.0597 Ops/s 113.0502 Ops/s $\textbf{\color{#35bf28}+15.93\%}$
test_reinforce_speed[reduce-overhead-None] 3.0086ms 2.8231ms 354.2202 Ops/s 337.5445 Ops/s $\color{#35bf28}+4.94\%$
test_reinforce_speed[reduce-overhead-backward] 8.0985ms 7.8455ms 127.4617 Ops/s 118.0975 Ops/s $\textbf{\color{#35bf28}+7.93\%}$
test_iql_speed[False-None] 20.5432ms 19.9648ms 50.0880 Ops/s 50.2090 Ops/s $\color{#d91a1a}-0.24\%$
test_iql_speed[False-backward] 36.5281ms 30.5834ms 32.6975 Ops/s 32.6911 Ops/s $\color{#35bf28}+0.02\%$
test_iql_speed[True-None] 8.8788ms 8.4294ms 118.6330 Ops/s 114.0232 Ops/s $\color{#35bf28}+4.04\%$
test_iql_speed[True-backward] 17.1503ms 16.4704ms 60.7151 Ops/s 59.2733 Ops/s $\color{#35bf28}+2.43\%$
test_iql_speed[reduce-overhead-None] 9.2894ms 8.4800ms 117.9248 Ops/s 113.5242 Ops/s $\color{#35bf28}+3.88\%$
test_iql_speed[reduce-overhead-backward] 17.5253ms 16.9339ms 59.0530 Ops/s 58.6674 Ops/s $\color{#35bf28}+0.66\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 8.0742ms 6.1503ms 162.5947 Ops/s 162.4539 Ops/s $\color{#35bf28}+0.09\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5765ms 0.3224ms 3.1015 KOps/s 2.6265 KOps/s $\textbf{\color{#35bf28}+18.08\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5549ms 0.3229ms 3.0967 KOps/s 2.7320 KOps/s $\textbf{\color{#35bf28}+13.35\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.2172ms 5.8641ms 170.5303 Ops/s 168.5629 Ops/s $\color{#35bf28}+1.17\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7078ms 0.2950ms 3.3895 KOps/s 2.6736 KOps/s $\textbf{\color{#35bf28}+26.78\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5007ms 0.2650ms 3.7732 KOps/s 2.7740 KOps/s $\textbf{\color{#35bf28}+36.02\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5060ms 1.2633ms 791.6077 Ops/s 697.6892 Ops/s $\textbf{\color{#35bf28}+13.46\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.4056ms 1.1801ms 847.4043 Ops/s 736.6171 Ops/s $\textbf{\color{#35bf28}+15.04\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 10.6569ms 6.1881ms 161.5994 Ops/s 164.4044 Ops/s $\color{#d91a1a}-1.71\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.5255ms 0.4426ms 2.2594 KOps/s 1.9099 KOps/s $\textbf{\color{#35bf28}+18.30\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6677ms 0.4218ms 2.3705 KOps/s 1.9801 KOps/s $\textbf{\color{#35bf28}+19.72\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.0555ms 5.8640ms 170.5324 Ops/s 167.1247 Ops/s $\color{#35bf28}+2.04\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9076ms 0.2935ms 3.4066 KOps/s 3.5100 KOps/s $\color{#d91a1a}-2.95\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5275ms 0.2966ms 3.3719 KOps/s 2.9451 KOps/s $\textbf{\color{#35bf28}+14.49\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1653ms 5.8290ms 171.5557 Ops/s 170.4778 Ops/s $\color{#35bf28}+0.63\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7435ms 0.2836ms 3.5257 KOps/s 3.2927 KOps/s $\textbf{\color{#35bf28}+7.08\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5031ms 0.2686ms 3.7224 KOps/s 3.3709 KOps/s $\textbf{\color{#35bf28}+10.43\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.3588ms 6.0840ms 164.3662 Ops/s 164.9047 Ops/s $\color{#d91a1a}-0.33\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.3544ms 0.4480ms 2.2322 KOps/s 1.9456 KOps/s $\textbf{\color{#35bf28}+14.73\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6201ms 0.4289ms 2.3316 KOps/s 2.0985 KOps/s $\textbf{\color{#35bf28}+11.11\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.4150ms 4.9893ms 200.4272 Ops/s 51.6439 Ops/s $\textbf{\color{#35bf28}+288.09\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 7.1820ms 2.3236ms 430.3612 Ops/s 683.1786 Ops/s $\textbf{\color{#d91a1a}-37.01\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 8.4067ms 1.2077ms 827.9923 Ops/s 782.0532 Ops/s $\textbf{\color{#35bf28}+5.87\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 7.2220ms 5.0629ms 197.5162 Ops/s 195.1208 Ops/s $\color{#35bf28}+1.23\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 8.2053ms 2.4073ms 415.4096 Ops/s 484.5106 Ops/s $\textbf{\color{#d91a1a}-14.26\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.5304ms 1.2311ms 812.2967 Ops/s 817.3455 Ops/s $\color{#d91a1a}-0.62\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.6244s 17.7198ms 56.4339 Ops/s 188.4668 Ops/s $\textbf{\color{#d91a1a}-70.06\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 4.0478ms 1.7981ms 556.1380 Ops/s 444.2825 Ops/s $\textbf{\color{#35bf28}+25.18\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 8.2057ms 1.3719ms 728.9062 Ops/s 711.6527 Ops/s $\color{#35bf28}+2.42\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 38.3145ms 34.9055ms 28.6488 Ops/s 28.6319 Ops/s $\color{#35bf28}+0.06\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.9797ms 18.3588ms 54.4697 Ops/s 57.0869 Ops/s $\color{#d91a1a}-4.58\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 41.3417ms 36.0299ms 27.7547 Ops/s 27.8526 Ops/s $\color{#d91a1a}-0.35\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 20.3940ms 18.6085ms 53.7390 Ops/s 55.4870 Ops/s $\color{#d91a1a}-3.15\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 40.5081ms 37.7193ms 26.5117 Ops/s 26.3740 Ops/s $\color{#35bf28}+0.52\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 21.3607ms 19.9844ms 50.0391 Ops/s 50.9042 Ops/s $\color{#d91a1a}-1.70\%$

@vmoens vmoens closed this Dec 31, 2025
@vmoens vmoens deleted the fixes++ branch December 31, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens