Skip to content

[BugFix] Handle Lock/RLock types in EnvCreator #3271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmoens merged 2 commits into from
Dec 31, 2025
Merged

[BugFix] Handle Lock/RLock types in EnvCreator #3271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddc43fa
Update
vmoens Dec 31, 2025
7226356
Update
vmoens Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions torchrl/envs/env_creator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from collections import OrderedDict
from collections.abc import Callable
from multiprocessing.sharedctypes import Synchronized
from multiprocessing.synchronize import Lock, RLock

import torch
from tensordict import TensorDictBase
Expand Down Expand Up @@ -141,8 +142,12 @@ def meta_data(self, value: EnvMetaData):

@staticmethod
def _is_mp_value(val):

return isinstance(val, (Synchronized,)) and hasattr(val, "_obj")
if isinstance(val, (Synchronized,)) and hasattr(val, "_obj"):
return True
# Also check for lock types which need to be shared across processes
if isinstance(val, (Lock, RLock)):
return True
return False

@classmethod
def _find_mp_values(cls, env_or_transform, values, prefix=()):
Expand Down
Loading