Skip to content

[Tests] Remove _utils_internal.py in tests #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vmoens merged 2 commits into from
Dec 31, 2025
Merged

[Tests] Remove _utils_internal.py in tests #3281

vmoens merged 2 commits into from
Dec 31, 2025

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Dec 31, 2025

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3281

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 33 Pending

As of commit abe667a with merge base 1ac0fd0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 31, 2025
@vmoens vmoens changed the title Remove _utils_internal.py in tests [Tests] Remove _utils_internal.py in tests Dec 31, 2025
@vmoens vmoens added the Tests Incomplete or broken unit tests label Dec 31, 2025
@vmoens vmoens merged commit 7866d11 into main Dec 31, 2025
87 of 101 checks passed
@vmoens vmoens deleted the move-test-utils branch December 31, 2025 10:59
@github-actions
Copy link

github-actions bot commented Dec 31, 2025

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 164. Improved: $\large\color{#35bf28}18$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 82.4890μs 81.6235μs 12.2514 KOps/s 11.8340 KOps/s $\color{#35bf28}+3.53\%$
test_tensor_to_bytestream_speed[torch.save] 0.1409ms 0.1405ms 7.1167 KOps/s 6.9206 KOps/s $\color{#35bf28}+2.83\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1266s 0.1261s 7.9293 Ops/s 7.8701 Ops/s $\color{#35bf28}+0.75\%$
test_tensor_to_bytestream_speed[numpy] 2.7824μs 2.7571μs 362.7033 KOps/s 367.0461 KOps/s $\color{#d91a1a}-1.18\%$
test_tensor_to_bytestream_speed[safetensors] 37.8434μs 37.6822μs 26.5377 KOps/s 26.4117 KOps/s $\color{#35bf28}+0.48\%$
test_simple 0.5535s 0.5526s 1.8097 Ops/s 1.7187 Ops/s $\textbf{\color{#35bf28}+5.30\%}$
test_transformed 1.1454s 1.1443s 0.8739 Ops/s 0.8605 Ops/s $\color{#35bf28}+1.56\%$
test_serial 1.6786s 1.6761s 0.5966 Ops/s 0.5848 Ops/s $\color{#35bf28}+2.02\%$
test_parallel 1.2719s 1.1582s 0.8634 Ops/s 0.8859 Ops/s $\color{#d91a1a}-2.54\%$
test_step_mdp_speed[True-True-True-True-True] 0.2005ms 44.0048μs 22.7248 KOps/s 22.0080 KOps/s $\color{#35bf28}+3.26\%$
test_step_mdp_speed[True-True-True-True-False] 56.8310μs 25.3061μs 39.5162 KOps/s 38.2690 KOps/s $\color{#35bf28}+3.26\%$
test_step_mdp_speed[True-True-True-False-True] 55.2510μs 25.3965μs 39.3755 KOps/s 39.6735 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[True-True-True-False-False] 41.8400μs 14.0684μs 71.0815 KOps/s 69.0261 KOps/s $\color{#35bf28}+2.98\%$
test_step_mdp_speed[True-True-False-True-True] 0.1133ms 48.7440μs 20.5153 KOps/s 20.1180 KOps/s $\color{#35bf28}+1.98\%$
test_step_mdp_speed[True-True-False-True-False] 55.7810μs 28.1772μs 35.4897 KOps/s 34.7955 KOps/s $\color{#35bf28}+1.99\%$
test_step_mdp_speed[True-True-False-False-True] 60.1210μs 28.2910μs 35.3470 KOps/s 35.4726 KOps/s $\color{#d91a1a}-0.35\%$
test_step_mdp_speed[True-True-False-False-False] 46.3810μs 16.6887μs 59.9208 KOps/s 57.6444 KOps/s $\color{#35bf28}+3.95\%$
test_step_mdp_speed[True-False-True-True-True] 85.4010μs 51.3852μs 19.4609 KOps/s 19.2149 KOps/s $\color{#35bf28}+1.28\%$
test_step_mdp_speed[True-False-True-True-False] 79.3320μs 30.9938μs 32.2645 KOps/s 31.8185 KOps/s $\color{#35bf28}+1.40\%$
test_step_mdp_speed[True-False-True-False-True] 67.6610μs 28.1138μs 35.5697 KOps/s 35.4889 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[True-False-True-False-False] 43.1900μs 16.9372μs 59.0415 KOps/s 58.5612 KOps/s $\color{#35bf28}+0.82\%$
test_step_mdp_speed[True-False-False-True-True] 90.3120μs 54.1514μs 18.4667 KOps/s 18.2664 KOps/s $\color{#35bf28}+1.10\%$
test_step_mdp_speed[True-False-False-True-False] 67.2210μs 33.7540μs 29.6261 KOps/s 29.8553 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[True-False-False-False-True] 60.6710μs 31.1097μs 32.1443 KOps/s 32.6770 KOps/s $\color{#d91a1a}-1.63\%$
test_step_mdp_speed[True-False-False-False-False] 51.2910μs 19.6838μs 50.8033 KOps/s 51.1790 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[False-True-True-True-True] 86.4910μs 52.0604μs 19.2085 KOps/s 19.6441 KOps/s $\color{#d91a1a}-2.22\%$
test_step_mdp_speed[False-True-True-True-False] 61.2110μs 31.2000μs 32.0513 KOps/s 32.0918 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[False-True-True-False-True] 2.2818ms 32.6342μs 30.6427 KOps/s 30.6548 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[False-True-True-False-False] 48.6710μs 18.7011μs 53.4728 KOps/s 53.4602 KOps/s $\color{#35bf28}+0.02\%$
test_step_mdp_speed[False-True-False-True-True] 92.1720μs 54.4531μs 18.3644 KOps/s 18.5177 KOps/s $\color{#d91a1a}-0.83\%$
test_step_mdp_speed[False-True-False-True-False] 75.2910μs 33.8971μs 29.5011 KOps/s 29.2990 KOps/s $\color{#35bf28}+0.69\%$
test_step_mdp_speed[False-True-False-False-True] 67.4810μs 34.9248μs 28.6329 KOps/s 28.8309 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[False-True-False-False-False] 53.3610μs 21.4615μs 46.5951 KOps/s 47.0385 KOps/s $\color{#d91a1a}-0.94\%$
test_step_mdp_speed[False-False-True-True-True] 93.2420μs 57.3798μs 17.4277 KOps/s 17.6639 KOps/s $\color{#d91a1a}-1.34\%$
test_step_mdp_speed[False-False-True-True-False] 72.2510μs 37.3112μs 26.8016 KOps/s 27.1445 KOps/s $\color{#d91a1a}-1.26\%$
test_step_mdp_speed[False-False-True-False-True] 75.8610μs 35.1347μs 28.4619 KOps/s 28.3719 KOps/s $\color{#35bf28}+0.32\%$
test_step_mdp_speed[False-False-True-False-False] 57.4210μs 21.1775μs 47.2199 KOps/s 46.5397 KOps/s $\color{#35bf28}+1.46\%$
test_step_mdp_speed[False-False-False-True-True] 89.8210μs 58.9866μs 16.9530 KOps/s 16.8786 KOps/s $\color{#35bf28}+0.44\%$
test_step_mdp_speed[False-False-False-True-False] 76.2620μs 38.9798μs 25.6543 KOps/s 25.2914 KOps/s $\color{#35bf28}+1.43\%$
test_step_mdp_speed[False-False-False-False-True] 70.8210μs 37.3305μs 26.7878 KOps/s 25.7927 KOps/s $\color{#35bf28}+3.86\%$
test_step_mdp_speed[False-False-False-False-False] 54.8210μs 23.5794μs 42.4098 KOps/s 41.5676 KOps/s $\color{#35bf28}+2.03\%$
test_non_tensor_env_rollout_speed[1000-single-True] 0.8904s 0.7955s 1.2571 Ops/s 1.2470 Ops/s $\color{#35bf28}+0.81\%$
test_non_tensor_env_rollout_speed[1000-single-False] 0.7487s 0.6533s 1.5307 Ops/s 1.4986 Ops/s $\color{#35bf28}+2.14\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-True] 1.8148s 1.7337s 0.5768 Ops/s 0.5653 Ops/s $\color{#35bf28}+2.03\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-False] 1.5788s 1.5016s 0.6660 Ops/s 0.6602 Ops/s $\color{#35bf28}+0.87\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-True] 2.0649s 1.9816s 0.5046 Ops/s 0.4972 Ops/s $\color{#35bf28}+1.50\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-False] 1.8252s 1.7492s 0.5717 Ops/s 0.5723 Ops/s $\color{#d91a1a}-0.11\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-True] 4.8355s 4.7074s 0.2124 Ops/s 0.2158 Ops/s $\color{#d91a1a}-1.55\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-False] 4.5259s 4.4355s 0.2255 Ops/s 0.2244 Ops/s $\color{#35bf28}+0.48\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-True] 2.1185s 2.0684s 0.4835 Ops/s 0.5008 Ops/s $\color{#d91a1a}-3.46\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-False] 1.7672s 1.6858s 0.5932 Ops/s 0.5671 Ops/s $\color{#35bf28}+4.61\%$
test_values[generalized_advantage_estimate-True-True] 10.9488ms 10.4946ms 95.2873 Ops/s 94.5465 Ops/s $\color{#35bf28}+0.78\%$
test_values[vec_generalized_advantage_estimate-True-True] 22.2609ms 17.9366ms 55.7520 Ops/s 56.0019 Ops/s $\color{#d91a1a}-0.45\%$
test_values[td0_return_estimate-False-False] 0.2083ms 0.1295ms 7.7205 KOps/s 7.7150 KOps/s $\color{#35bf28}+0.07\%$
test_values[td1_return_estimate-False-False] 28.2974ms 27.8319ms 35.9300 Ops/s 35.3306 Ops/s $\color{#35bf28}+1.70\%$
test_values[vec_td1_return_estimate-False-False] 19.2571ms 17.8852ms 55.9120 Ops/s 55.3090 Ops/s $\color{#35bf28}+1.09\%$
test_values[td_lambda_return_estimate-True-False] 42.9633ms 41.4204ms 24.1427 Ops/s 23.9906 Ops/s $\color{#35bf28}+0.63\%$
test_values[vec_td_lambda_return_estimate-True-False] 18.8613ms 17.8722ms 55.9528 Ops/s 56.0817 Ops/s $\color{#d91a1a}-0.23\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.3887ms 9.2544ms 108.0568 Ops/s 105.2775 Ops/s $\color{#35bf28}+2.64\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.7989ms 1.5570ms 642.2579 Ops/s 664.3851 Ops/s $\color{#d91a1a}-3.33\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5343ms 0.4214ms 2.3730 KOps/s 2.3642 KOps/s $\color{#35bf28}+0.37\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 34.9576ms 34.4443ms 29.0324 Ops/s 28.4838 Ops/s $\color{#35bf28}+1.93\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 2.2585ms 1.8152ms 550.9083 Ops/s 550.7041 Ops/s $\color{#35bf28}+0.04\%$
test_dqn_speed[False-None] 1.8332ms 1.4272ms 700.6603 Ops/s 698.9200 Ops/s $\color{#35bf28}+0.25\%$
test_dqn_speed[False-backward] 2.0245ms 1.9418ms 514.9903 Ops/s 515.4910 Ops/s $\color{#d91a1a}-0.10\%$
test_dqn_speed[True-None] 0.6902ms 0.5382ms 1.8581 KOps/s 1.8421 KOps/s $\color{#35bf28}+0.87\%$
test_dqn_speed[True-backward] 1.0530ms 0.9875ms 1.0127 KOps/s 872.7592 Ops/s $\textbf{\color{#35bf28}+16.03\%}$
test_dqn_speed[reduce-overhead-None] 0.6627ms 0.5327ms 1.8773 KOps/s 1.8450 KOps/s $\color{#35bf28}+1.75\%$
test_dqn_speed[reduce-overhead-backward] 1.0304ms 0.9906ms 1.0095 KOps/s 938.0190 Ops/s $\textbf{\color{#35bf28}+7.62\%}$
test_ddpg_speed[False-None] 3.2698ms 2.9344ms 340.7826 Ops/s 344.2583 Ops/s $\color{#d91a1a}-1.01\%$
test_ddpg_speed[False-backward] 4.2429ms 4.1355ms 241.8091 Ops/s 238.5857 Ops/s $\color{#35bf28}+1.35\%$
test_ddpg_speed[True-None] 1.9024ms 1.4077ms 710.3857 Ops/s 702.8671 Ops/s $\color{#35bf28}+1.07\%$
test_ddpg_speed[True-backward] 2.8892ms 2.3999ms 416.6895 Ops/s 416.9181 Ops/s $\color{#d91a1a}-0.05\%$
test_ddpg_speed[reduce-overhead-None] 1.8227ms 1.3975ms 715.5750 Ops/s 700.7249 Ops/s $\color{#35bf28}+2.12\%$
test_ddpg_speed[reduce-overhead-backward] 2.4581ms 2.3744ms 421.1533 Ops/s 377.2495 Ops/s $\textbf{\color{#35bf28}+11.64\%}$
test_sac_speed[False-None] 8.4424ms 8.0303ms 124.5276 Ops/s 121.1512 Ops/s $\color{#35bf28}+2.79\%$
test_sac_speed[False-backward] 11.7706ms 11.3242ms 88.3061 Ops/s 87.2266 Ops/s $\color{#35bf28}+1.24\%$
test_sac_speed[True-None] 2.5625ms 2.1482ms 465.5123 Ops/s 462.6177 Ops/s $\color{#35bf28}+0.63\%$
test_sac_speed[True-backward] 4.2511ms 4.0771ms 245.2750 Ops/s 246.6227 Ops/s $\color{#d91a1a}-0.55\%$
test_sac_speed[reduce-overhead-None] 2.3098ms 2.1346ms 468.4697 Ops/s 446.2142 Ops/s $\color{#35bf28}+4.99\%$
test_sac_speed[reduce-overhead-backward] 4.1484ms 4.0198ms 248.7678 Ops/s 248.0737 Ops/s $\color{#35bf28}+0.28\%$
test_redq_speed[False-None] 14.9263ms 10.4827ms 95.3953 Ops/s 90.9215 Ops/s $\color{#35bf28}+4.92\%$
test_redq_speed[False-backward] 20.5681ms 18.1523ms 55.0895 Ops/s 54.9253 Ops/s $\color{#35bf28}+0.30\%$
test_redq_speed[True-None] 5.0579ms 4.4545ms 224.4900 Ops/s 227.1071 Ops/s $\color{#d91a1a}-1.15\%$
test_redq_speed[True-backward] 10.1262ms 9.8112ms 101.9247 Ops/s 95.7938 Ops/s $\textbf{\color{#35bf28}+6.40\%}$
test_redq_speed[reduce-overhead-None] 4.8243ms 4.3432ms 230.2427 Ops/s 227.8459 Ops/s $\color{#35bf28}+1.05\%$
test_redq_speed[reduce-overhead-backward] 10.2835ms 9.9455ms 100.5482 Ops/s 98.5518 Ops/s $\color{#35bf28}+2.03\%$
test_redq_deprec_speed[False-None] 11.6529ms 11.1862ms 89.3955 Ops/s 91.1944 Ops/s $\color{#d91a1a}-1.97\%$
test_redq_deprec_speed[False-backward] 17.0688ms 16.2059ms 61.7057 Ops/s 63.8448 Ops/s $\color{#d91a1a}-3.35\%$
test_redq_deprec_speed[True-None] 4.1383ms 3.6606ms 273.1799 Ops/s 269.9190 Ops/s $\color{#35bf28}+1.21\%$
test_redq_deprec_speed[True-backward] 8.0139ms 7.7000ms 129.8697 Ops/s 125.0268 Ops/s $\color{#35bf28}+3.87\%$
test_redq_deprec_speed[reduce-overhead-None] 4.0130ms 3.6392ms 274.7852 Ops/s 273.9620 Ops/s $\color{#35bf28}+0.30\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.9170ms 7.6814ms 130.1850 Ops/s 127.0832 Ops/s $\color{#35bf28}+2.44\%$
test_td3_speed[False-None] 8.2645ms 8.1200ms 123.1523 Ops/s 123.3433 Ops/s $\color{#d91a1a}-0.15\%$
test_td3_speed[False-backward] 11.4498ms 11.0371ms 90.6039 Ops/s 91.0628 Ops/s $\color{#d91a1a}-0.50\%$
test_td3_speed[True-None] 1.8564ms 1.8194ms 549.6285 Ops/s 542.4141 Ops/s $\color{#35bf28}+1.33\%$
test_td3_speed[True-backward] 3.7558ms 3.6242ms 275.9204 Ops/s 225.2504 Ops/s $\textbf{\color{#35bf28}+22.49\%}$
test_td3_speed[reduce-overhead-None] 1.8322ms 1.7857ms 560.0009 Ops/s 557.7316 Ops/s $\color{#35bf28}+0.41\%$
test_td3_speed[reduce-overhead-backward] 3.8508ms 3.6863ms 271.2722 Ops/s 270.6495 Ops/s $\color{#35bf28}+0.23\%$
test_cql_speed[False-None] 28.9535ms 26.4579ms 37.7960 Ops/s 38.4017 Ops/s $\color{#d91a1a}-1.58\%$
test_cql_speed[False-backward] 38.3948ms 35.3210ms 28.3118 Ops/s 28.7889 Ops/s $\color{#d91a1a}-1.66\%$
test_cql_speed[True-None] 12.5041ms 12.2519ms 81.6200 Ops/s 79.5522 Ops/s $\color{#35bf28}+2.60\%$
test_cql_speed[True-backward] 18.6919ms 18.0737ms 55.3292 Ops/s 54.9867 Ops/s $\color{#35bf28}+0.62\%$
test_cql_speed[reduce-overhead-None] 15.7082ms 12.7278ms 78.5680 Ops/s 81.1904 Ops/s $\color{#d91a1a}-3.23\%$
test_cql_speed[reduce-overhead-backward] 18.7042ms 18.1895ms 54.9768 Ops/s 56.0440 Ops/s $\color{#d91a1a}-1.90\%$
test_a2c_speed[False-None] 5.6761ms 5.4775ms 182.5650 Ops/s 178.7498 Ops/s $\color{#35bf28}+2.13\%$
test_a2c_speed[False-backward] 12.2106ms 11.8570ms 84.3381 Ops/s 82.5540 Ops/s $\color{#35bf28}+2.16\%$
test_a2c_speed[True-None] 4.3061ms 3.6922ms 270.8428 Ops/s 258.0558 Ops/s $\color{#35bf28}+4.96\%$
test_a2c_speed[True-backward] 8.7847ms 8.5327ms 117.1960 Ops/s 116.0421 Ops/s $\color{#35bf28}+0.99\%$
test_a2c_speed[reduce-overhead-None] 3.8302ms 3.7058ms 269.8489 Ops/s 263.1134 Ops/s $\color{#35bf28}+2.56\%$
test_a2c_speed[reduce-overhead-backward] 8.9482ms 8.7014ms 114.9244 Ops/s 112.5901 Ops/s $\color{#35bf28}+2.07\%$
test_ppo_speed[False-None] 6.2348ms 5.8083ms 172.1684 Ops/s 167.7555 Ops/s $\color{#35bf28}+2.63\%$
test_ppo_speed[False-backward] 12.8208ms 12.4066ms 80.6021 Ops/s 79.1156 Ops/s $\color{#35bf28}+1.88\%$
test_ppo_speed[True-None] 3.9785ms 3.6163ms 276.5276 Ops/s 271.0005 Ops/s $\color{#35bf28}+2.04\%$
test_ppo_speed[True-backward] 8.5907ms 8.4436ms 118.4328 Ops/s 116.2131 Ops/s $\color{#35bf28}+1.91\%$
test_ppo_speed[reduce-overhead-None] 3.7628ms 3.5780ms 279.4865 Ops/s 271.8210 Ops/s $\color{#35bf28}+2.82\%$
test_ppo_speed[reduce-overhead-backward] 9.1508ms 8.6562ms 115.5247 Ops/s 115.3620 Ops/s $\color{#35bf28}+0.14\%$
test_reinforce_speed[False-None] 5.1145ms 4.6079ms 217.0189 Ops/s 216.7758 Ops/s $\color{#35bf28}+0.11\%$
test_reinforce_speed[False-backward] 8.3802ms 7.4145ms 134.8708 Ops/s 135.2045 Ops/s $\color{#d91a1a}-0.25\%$
test_reinforce_speed[True-None] 3.0851ms 2.8762ms 347.6761 Ops/s 347.8379 Ops/s $\color{#d91a1a}-0.05\%$
test_reinforce_speed[True-backward] 7.9093ms 7.6579ms 130.5841 Ops/s 129.5022 Ops/s $\color{#35bf28}+0.84\%$
test_reinforce_speed[reduce-overhead-None] 3.3191ms 2.8652ms 349.0099 Ops/s 341.4270 Ops/s $\color{#35bf28}+2.22\%$
test_reinforce_speed[reduce-overhead-backward] 8.1335ms 7.8652ms 127.1418 Ops/s 118.9272 Ops/s $\textbf{\color{#35bf28}+6.91\%}$
test_iql_speed[False-None] 25.8715ms 20.4525ms 48.8938 Ops/s 51.1458 Ops/s $\color{#d91a1a}-4.40\%$
test_iql_speed[False-backward] 31.0851ms 30.5367ms 32.7474 Ops/s 33.5422 Ops/s $\color{#d91a1a}-2.37\%$
test_iql_speed[True-None] 8.9865ms 8.4658ms 118.1220 Ops/s 117.9162 Ops/s $\color{#35bf28}+0.17\%$
test_iql_speed[True-backward] 17.4249ms 16.6763ms 59.9653 Ops/s 59.0332 Ops/s $\color{#35bf28}+1.58\%$
test_iql_speed[reduce-overhead-None] 9.0019ms 8.5040ms 117.5912 Ops/s 115.5293 Ops/s $\color{#35bf28}+1.78\%$
test_iql_speed[reduce-overhead-backward] 17.6122ms 17.1375ms 58.3516 Ops/s 58.0469 Ops/s $\color{#35bf28}+0.52\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 8.2344ms 6.1777ms 161.8716 Ops/s 161.3217 Ops/s $\color{#35bf28}+0.34\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5383ms 0.2904ms 3.4434 KOps/s 2.6578 KOps/s $\textbf{\color{#35bf28}+29.56\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7523ms 0.2727ms 3.6665 KOps/s 2.8977 KOps/s $\textbf{\color{#35bf28}+26.53\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 7.3884ms 5.9038ms 169.3837 Ops/s 169.7911 Ops/s $\color{#d91a1a}-0.24\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1090ms 0.3075ms 3.2519 KOps/s 2.9869 KOps/s $\textbf{\color{#35bf28}+8.87\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.8805ms 0.3566ms 2.8040 KOps/s 3.3946 KOps/s $\textbf{\color{#d91a1a}-17.40\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5869ms 1.3603ms 735.1257 Ops/s 707.6760 Ops/s $\color{#35bf28}+3.88\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5563ms 1.2887ms 775.9583 Ops/s 743.8781 Ops/s $\color{#35bf28}+4.31\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 9.4318ms 6.1527ms 162.5305 Ops/s 163.7404 Ops/s $\color{#d91a1a}-0.74\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.0510ms 0.4371ms 2.2878 KOps/s 2.0818 KOps/s $\textbf{\color{#35bf28}+9.89\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8782ms 0.4742ms 2.1090 KOps/s 2.1586 KOps/s $\color{#d91a1a}-2.30\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.2583ms 5.8319ms 171.4720 Ops/s 167.9460 Ops/s $\color{#35bf28}+2.10\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9704ms 0.2831ms 3.5329 KOps/s 2.8690 KOps/s $\textbf{\color{#35bf28}+23.14\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5910ms 0.3532ms 2.8315 KOps/s 3.0082 KOps/s $\textbf{\color{#d91a1a}-5.87\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.3562ms 5.7902ms 172.7065 Ops/s 170.3910 Ops/s $\color{#35bf28}+1.36\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.0394ms 0.2987ms 3.3476 KOps/s 2.8898 KOps/s $\textbf{\color{#35bf28}+15.84\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5398ms 0.3196ms 3.1286 KOps/s 2.9994 KOps/s $\color{#35bf28}+4.31\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.4473ms 6.0770ms 164.5547 Ops/s 164.9095 Ops/s $\color{#d91a1a}-0.22\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.4383ms 0.4432ms 2.2562 KOps/s 2.1246 KOps/s $\textbf{\color{#35bf28}+6.19\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8605ms 0.4169ms 2.3985 KOps/s 2.3322 KOps/s $\color{#35bf28}+2.84\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.3536ms 4.9452ms 202.2177 Ops/s 195.1810 Ops/s $\color{#35bf28}+3.61\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 6.4213ms 2.3053ms 433.7800 Ops/s 407.1174 Ops/s $\textbf{\color{#35bf28}+6.55\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 8.2697ms 1.2525ms 798.3772 Ops/s 886.1663 Ops/s $\textbf{\color{#d91a1a}-9.91\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 8.1007ms 5.0671ms 197.3529 Ops/s 52.3830 Ops/s $\textbf{\color{#35bf28}+276.75\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.6161s 14.3813ms 69.5347 Ops/s 549.4398 Ops/s $\textbf{\color{#d91a1a}-87.34\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.0105ms 0.9347ms 1.0699 KOps/s 821.0899 Ops/s $\textbf{\color{#35bf28}+30.30\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 7.5411ms 5.2430ms 190.7322 Ops/s 188.2703 Ops/s $\color{#35bf28}+1.31\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 9.4292ms 2.2651ms 441.4721 Ops/s 442.9620 Ops/s $\color{#d91a1a}-0.34\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.2907ms 1.3621ms 734.1683 Ops/s 697.3048 Ops/s $\textbf{\color{#35bf28}+5.29\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 37.4337ms 34.7349ms 28.7895 Ops/s 28.2771 Ops/s $\color{#35bf28}+1.81\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.9279ms 18.0304ms 55.4619 Ops/s 55.1612 Ops/s $\color{#35bf28}+0.55\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 37.8527ms 35.4239ms 28.2295 Ops/s 27.6622 Ops/s $\color{#35bf28}+2.05\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.7233ms 18.2640ms 54.7525 Ops/s 53.2853 Ops/s $\color{#35bf28}+2.75\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 38.9825ms 37.4425ms 26.7077 Ops/s 26.4449 Ops/s $\color{#35bf28}+0.99\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 21.6166ms 19.7334ms 50.6754 Ops/s 48.6033 Ops/s $\color{#35bf28}+4.26\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests Incomplete or broken unit tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens