Skip to content

Conversation

@michalgregor
Copy link
Contributor

Description

I added the missing .to(device) call to TransformersWrapper's _from_transformers_generate_history.

Motivation and Context

It seems that TransformersWrapper's _from_transformers_generate_history misses a .to(device) call after it performs history.apply_chat_template, i.e. the resulting token tensor is not on the correct device and an exception gets raised later in the result = self._generate_from_tokens( call.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • [ X ] Bug fix (non-breaking change which fixes an issue)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

Added a missing .to(device) in TransformersWrapper's _from_transformers_generate_history.
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 4, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3289

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Jan 4, 2026

Hi @michalgregor!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @michalgregor
This looks sound to me, can you sign the CLA? Then happy to merge

@michalgregor
Copy link
Contributor Author

I took care of the CLA just now; thank you! 🙂

@meta-cla
Copy link

meta-cla bot commented Jan 5, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2026
@vmoens vmoens changed the title Added a missing .to(device) call in _from_transformers_generate_history [BugFix] Added a missing .to(device) call in _from_transformers_generate_history Jan 5, 2026
@vmoens vmoens merged commit 807e9fe into pytorch:main Jan 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants