Skip to content

[BugFix] Fix TDLambdaEstimator for torch.compile compatibility #3302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmoens merged 2 commits into from
Jan 8, 2026
Merged

[BugFix] Fix TDLambdaEstimator for torch.compile compatibility #3302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c68a442
Update
vmoens Jan 8, 2026
f9679cb
Update
vmoens Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions torchrl/objectives/value/advantages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,6 +1081,16 @@ def __init__(
self.vectorized = vectorized
self.time_dim = time_dim

@property
def vectorized(self):
if is_dynamo_compiling():
return False
return self._vectorized

@vectorized.setter
def vectorized(self, value):
self._vectorized = value

@_self_set_skip_existing
@_self_set_grad_enabled
@dispatch
Expand Down Expand Up @@ -1206,6 +1216,8 @@ def value_estimate(
if steps_to_next_obs is not None:
gamma = gamma ** steps_to_next_obs.view_as(reward)

if self.lmbda.device != device:
self.lmbda = self.lmbda.to(device)
lmbda = self.lmbda
if self.average_rewards:
reward = reward - reward.mean()
Expand Down
Loading