-
Notifications
You must be signed in to change notification settings - Fork 80
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix perf dashboard querying for individual suite (#5973)
This is reported by @yf225 and @ezyang that when selecting dynamic or blueberries suites on the perf dashboard, an empty page is returned, for example https://hud.pytorch.org/benchmark/dynamic/inductor_aot_inductor?dashboard=torchinductor&startTime=Fri,%2015%20Nov%202024%2021:57:42%20GMT&stopTime=Fri,%2022%20Nov%202024%2021:57:42%20GMT&granularity=hour&mode=inference&dtype=bfloat16&deviceName=cuda%20(a100)&lBranch=main&lCommit=d65f194ab91055d1a104163dce93d5580fec2d28&rBranch=main&rCommit=2b39a8db7741b816b03677a9c6fec1af05640dee This is a regression bug coming from #5769 where I set the suite parameter incorrectly: * Rockset set the default of this parameter to query everything. The CH query missed that. * The old code didn't set any suite and relied on the above default behavior. I also update echarts package to fix the window not defined error when the page is rendered on the server-side. ### Testing Selecting individual suite is displayed correctly now https://torchci-git-fork-huydhn-fix-dashboard-augmentdata-fbopensource.vercel.app/benchmark/dynamic/inductor_with_cudagraphs_freezing?dashboard=torchinductor&startTime=Fri,%2015%20Nov%202024%2022:02:08%20GMT&stopTime=Fri,%2022%20Nov%202024%2022:02:08%20GMT&granularity=hour&mode=inference&dtype=bfloat16&deviceName=cuda%20(a100)&lBranch=main&lCommit=d65f194ab91055d1a104163dce93d5580fec2d28&rBranch=main&rCommit=2b39a8db7741b816b03677a9c6fec1af05640dee
- Loading branch information
Showing
4 changed files
with
17 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4183,13 +4183,13 @@ echarts-for-react@^3.0.2: | |
fast-deep-equal "^3.1.3" | ||
size-sensor "^1.0.1" | ||
|
||
echarts@^5.3.2: | ||
version "5.3.2" | ||
resolved "https://registry.npmjs.org/echarts/-/echarts-5.3.2.tgz" | ||
integrity sha512-LWCt7ohOKdJqyiBJ0OGBmE9szLdfA9sGcsMEi+GGoc6+Xo75C+BkcT/6NNGRHAWtnQl2fNow05AQjznpap28TQ== | ||
echarts@^5.5.1: | ||
version "5.5.1" | ||
resolved "https://registry.yarnpkg.com/echarts/-/echarts-5.5.1.tgz#8dc9c68d0c548934bedcb5f633db07ed1dd2101c" | ||
integrity sha512-Fce8upazaAXUVUVsjgV6mBnGuqgO+JNDlcgF79Dksy4+wgGpQB2lmYoO4TSweFg/mZITdpGHomw/cNBJZj1icA== | ||
dependencies: | ||
tslib "2.3.0" | ||
zrender "5.3.1" | ||
zrender "5.6.0" | ||
|
||
[email protected], ee-first@~1.1.1: | ||
version "1.1.1" | ||
|
@@ -8740,9 +8740,9 @@ yocto-queue@^0.1.0: | |
resolved "https://registry.yarnpkg.com/yocto-queue/-/yocto-queue-0.1.0.tgz#0294eb3dee05028d31ee1a5fa2c556a6aaf10a1b" | ||
integrity sha512-rVksvsnNCdJ/ohGc6xgPwyN8eheCxsiLM8mxuE/t/mOVqJewPuO1miLpTHQiRgTKCLexL4MeAFVagts7HmNZ2Q== | ||
|
||
zrender@5.3.1: | ||
version "5.3.1" | ||
resolved "https://registry.npmjs.org/zrender/-/zrender-5.3.1.tgz" | ||
integrity sha512-7olqIjy0gWfznKr6vgfnGBk7y4UtdMvdwFmK92vVQsQeDPyzkHW1OlrLEKg6GHz1W5ePf0FeN1q2vkl/HFqhXw== | ||
zrender@5.6.0: | ||
version "5.6.0" | ||
resolved "https://registry.yarnpkg.com/zrender/-/zrender-5.6.0.tgz#01325b0bb38332dd5e87a8dbee7336cafc0f4a5b" | ||
integrity sha512-uzgraf4njmmHAbEUxMJ8Oxg+P3fT04O+9p7gY+wJRVxo8Ge+KmYv0WJev945EH4wFuc4OY2NLXz46FZrWS9xJg== | ||
dependencies: | ||
tslib "2.3.0" |