[HUD] Add job-status "QUEUED"

[yangw-dev]

Overview

#5822
Add Queued status

Details

• add Queued value in conclusion based on job.status
• add the UI changes in both the commit view, and the main trunk view.
• replace all string such as 'pending` to enum value JobStatus

Notice

there are other sqls are using 'pending' as default conclusion for empty conclusion value , may create followup issues to address those.

Next Steps

replace the text to react-icons for rendering.

[vercel]

@yangw-dev is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
torchci	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 10:12pm

[huydhn]

At first glance, I think we should keep the same familiar yellow ? for pending job as the majority of them will be in pending state (screenshot). IMO, this helps me keep the familiar context when I see them and only focus on the queueing part that stands out (dark/black Q):

[huydhn]

I think you do have the information about the total number of jobs in the queue. An interesting feature here would be to use the same gray color as the ~ character for queued job as long as the their number is lower than a threshold, i.e. 50 jobs in the queue. This signifies that everything operates normally.

On the other hand, if the number of queue jobs is higher than that threshold, meaning something is not right, we can switch the color to orange, and it would surely catch our attention.

This can be done in a follow-up PR though I think

[huydhn]

Nit: Could we get rid of the show log part when the job is pending or in queue as there is nothing to show there yet except and S3 error that the key doesn't exist?

[yangw-dev]

character

Hi Huy, I will replace all of those text (S,Q,P) with react-icon in next PR, so this is temporary, we can def discuss the color change in next PR

[yangw-dev]

Nit: Could we get rid of the show log part when the job is pending or in queue as there is nothing to show there yet except and S3 error that the key doesn't exist?

I agree the log is not very useful here, @clee2000 , thoughts?

[yangw-dev]

I think you do have the information about the total number of jobs in the queue. An interesting feature here would be to use the same gray color as the ~ character for queued job as long as the their number is lower than a threshold, i.e. 50 jobs in the queue. This signifies that everything operates normally.

On the other hand, if the number of queue jobs is higher than that threshold, meaning something is not right, we can switch the color to orange, and it would surely catch our attention.

This can be done in a follow-up PR though I think

I changed the queued signal to grey for general purpose now

[clee2000]

Personally I prefer yellow over gray for queued, but given you're going to change the icons in a different PR I don't think it matters much