Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling][Hud ]Add Performance Render Profiler wrapper #5905

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Nov 13, 2024

Overview

We want to investigate the performance of components in HUD, react-profiler is a good tool to give us the render time feedback.

Altenative

You can def choose the profile tool in Chrome Extension: React Dev Tools, for me this is easy to target.

Notice

Only use it during local development. Though react profiler is light-weight, it is still takes memories on application.

Screenshot logging demo

Tracking render time for HudTable's and its children's.
Nov-12-2024 16-51-44

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 9:42pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2024
@yangw-dev yangw-dev marked this pull request as ready for review November 13, 2024 00:56
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not, let's try this out!

@yangw-dev yangw-dev merged commit 9abd4d9 into main Nov 15, 2024
7 checks passed
@yangw-dev yangw-dev deleted the addProfilerTestTool branch November 15, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants