Cleanup unused class variable memory_usage_limit_mb as per TODO in torchrec metric_module #3351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81322330 |
aliafzal
pushed a commit
to aliafzal/torchrec
that referenced
this pull request
Sep 4, 2025
…rchrec metric_module (pytorch#3351) Summary: As per the TODO, cleaning up memory_usage_limit_mb class variable and associated call sites. Reviewed By: aliafzal Differential Revision: D81322330
aliafzal
force-pushed
the
export-D81322330
branch
from
1e02915 to
f9e8274
Compare
aliafzal
pushed a commit
to aliafzal/torchrec
that referenced
this pull request
Sep 4, 2025
…rchrec metric_module (pytorch#3351) Summary: As per the TODO, cleaning up memory_usage_limit_mb class variable and associated call sites. Reviewed By: aliafzal Differential Revision: D81322330
aliafzal
force-pushed
the
export-D81322330
branch
from
f9e8274 to
b0fc5ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81322330 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D81322330 |
aliafzal
pushed a commit
to aliafzal/torchrec
that referenced
this pull request
Sep 4, 2025
…rchrec metric_module (pytorch#3351) Summary: Pull Request resolved: pytorch#3351 As per the TODO, cleaning up memory_usage_limit_mb class variable and associated call sites. Reviewed By: aliafzal Differential Revision: D81322330
aliafzal
force-pushed
the
export-D81322330
branch
2 times, most recently
from
dc093d9 to
2e9d35a
Compare
aliafzal
pushed a commit
to aliafzal/torchrec
that referenced
this pull request
Sep 5, 2025
…rchrec metric_module (pytorch#3351) Summary: As per the TODO, cleaning up memory_usage_limit_mb class variable and associated call sites. Reviewed By: aliafzal Differential Revision: D81322330
|
This pull request was exported from Phabricator. Differential Revision: D81322330 |
aliafzal
pushed a commit
to aliafzal/torchrec
that referenced
this pull request
Sep 5, 2025
…rchrec metric_module (pytorch#3351) Summary: Pull Request resolved: pytorch#3351 As per the TODO, cleaning up memory_usage_limit_mb class variable and associated call sites. Reviewed By: aliafzal Differential Revision: D81322330
aliafzal
force-pushed
the
export-D81322330
branch
from
2e9d35a to
b9a3575
Compare
aliafzal
pushed a commit
to aliafzal/torchrec
that referenced
this pull request
Sep 8, 2025
…rchrec metric_module (pytorch#3351) Summary: As per the TODO, cleaning up memory_usage_limit_mb class variable and associated call sites. Reviewed By: aliafzal Differential Revision: D81322330
aliafzal
force-pushed
the
export-D81322330
branch
from
b9a3575 to
feaaf71
Compare
…rchrec metric_module (pytorch#3351) Summary: Pull Request resolved: pytorch#3351 As per the TODO, cleaning up memory_usage_limit_mb class variable and associated call sites. Reviewed By: aliafzal Differential Revision: D81322330
|
This pull request was exported from Phabricator. Differential Revision: D81322330 |
aliafzal
force-pushed
the
export-D81322330
branch
from
feaaf71 to
c9207ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As per the TODO, cleaning up memory_usage_limit_mb class variable and associated call sites.
Reviewed By: aliafzal
Differential Revision: D81322330