-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full DPO Distributed #2275
Open
sam-pi
wants to merge
18
commits into
pytorch:main
Choose a base branch
from
sam-pi:add-feature-full-dpo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,361
−18
Open
Full DPO Distributed #2275
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b96255b
full dpo configs, distributed recipe, and integration tests
sam-pi 761b718
disable dropout, ref model setup, minor doc update
sam-pi 753e822
Merge remote-tracking branch 'upstream/main' into HEAD
SalmanMohammadi 0f90093
updating full recipe
SalmanMohammadi ebed89c
updating recipe
SalmanMohammadi aff595f
removing 70B full dpo config until multi-node support is available
sam-pi 431f269
minor update to avoid _ref_model self reference
sam-pi c63e9e8
clean up rank zero logs and ref_checkpointer
sam-pi ebf288a
remove unncessary save/load test and update to 2 GPUs
sam-pi ba12bb4
fix: Metrics weren't running and synced across devices
bogdansalyp 6139096
fix: Fixed tokens_per_second_per_gpu
bogdansalyp 2a4ca92
fix: Fixed torch.distributed naming
bogdansalyp 7f94b07
fix: tokens_per_second_pre_gpu fixed for full dpo
bogdansalyp 1a673df
fix: Added running metrics to full_dpo_distributed
bogdansalyp 16821c4
Merge pull request #2 from bogdansalyp/fix/running_metrics_and_sync_l…
sam-pi d052271
fix: num_tokens all_reduce crash in DPO recipes
bogdansalyp f9fedc4
Merge pull request #3 from bogdansalyp/fix/num_tokens-tensor-issue
sam-pi a0ac5aa
delete ref logits and improved default full dpo config
sam-pi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
# Config for multi-device full DPO alignment in full_dpo_distributed.py | ||
# using a Llama3.1 70B model | ||
# | ||
# This config assumes that you've run the following command before launching | ||
# this run: | ||
# tune download meta-llama/Meta-Llama-3.1-70B-Instruct --output-dir /tmp/Meta-Llama-3.1-70B-Instruct --ignore-patterns "original/consolidated.00.pth" | ||
# | ||
# To launch on 2 devices, run the following command from root: | ||
# tune run --nnodes 1 --nproc_per_node 2 full_dpo_distributed --config llama3_1/70B_full_dpo | ||
# | ||
# You can add specific overrides through the command line. For example | ||
# to override the checkpointer directory while launching training | ||
# you can run: | ||
# tune run --nnodes 1 --nproc_per_node 2 full_dpo_distributed --config llama3_1/70B_full_dpo checkpointer.checkpoint_dir=<YOUR_CHECKPOINT_DIR> | ||
# | ||
# This config works best when the model is being fine-tuned on 2+ nodes with 8 H100s. | ||
|
||
output_dir: /tmp/torchtune/llama3_1_70B/full_dpo # /tmp may be deleted by your system. Change it to your preference. | ||
|
||
# Model Arguments | ||
model: | ||
_component_: torchtune.models.llama3_1.llama3_1_70b | ||
|
||
# Tokenizer | ||
tokenizer: | ||
_component_: torchtune.models.llama3.llama3_tokenizer | ||
path: /tmp/Meta-Llama-3.1-70B-Instruct/original/tokenizer.model | ||
max_seq_len: 1024 # higher increases memory | ||
|
||
checkpointer: | ||
_component_: torchtune.training.FullModelHFCheckpointer | ||
checkpoint_dir: /tmp/Meta-Llama-3.1-70B-Instruct/ | ||
checkpoint_files: | ||
filename_format: model-{}-of-{}.safetensors | ||
max_filename: "00030" | ||
recipe_checkpoint: null | ||
output_dir: ${output_dir} | ||
model_type: LLAMA3 | ||
resume_from_checkpoint: False | ||
|
||
ref_checkpointer: | ||
_component_: torchtune.training.FullModelHFCheckpointer | ||
checkpoint_dir: /tmp/Meta-Llama-3.1-70B-Instruct/ | ||
checkpoint_files: | ||
filename_format: model-{}-of-{}.safetensors | ||
max_filename: "00030" | ||
recipe_checkpoint: null | ||
output_dir: ${output_dir} | ||
model_type: LLAMA3 | ||
|
||
# Dataset and Sampler | ||
dataset: | ||
_component_: torchtune.datasets.stack_exchange_paired_dataset | ||
seed: null | ||
shuffle: True | ||
batch_size: 4 | ||
|
||
# Optimizer and Scheduler | ||
optimizer: | ||
_component_: torch.optim.AdamW | ||
fused: True | ||
weight_decay: 0.05 | ||
lr: 1e-6 | ||
lr_scheduler: | ||
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup | ||
num_warmup_steps: 100 | ||
|
||
loss: | ||
_component_: torchtune.rlhf.loss.DPOLoss | ||
beta: 0.05 | ||
label_smoothing: 0 | ||
|
||
# Training | ||
epochs: 1 | ||
max_steps_per_epoch: 1000 | ||
gradient_accumulation_steps: 8 # Use to increase effective batch size | ||
compile: False # torch.compile the model + loss, True increases speed + decreases memory | ||
|
||
# Logging | ||
metric_logger: | ||
_component_: torchtune.training.metric_logging.DiskLogger | ||
log_dir: ${output_dir}/logs | ||
log_every_n_steps: 1 | ||
log_peak_memory_stats: True | ||
|
||
# Environment | ||
device: cuda | ||
dtype: bf16 | ||
|
||
# Memory management | ||
enable_activation_checkpointing: True # True reduces memory | ||
enable_activation_offloading: False # True reduces memory |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
# Config for multi-device full DPO alignment in full_dpo_distributed.py | ||
# using a Llama3.1 8B model | ||
# | ||
# This config assumes that you've run the following command before launching | ||
# this run: | ||
# tune download meta-llama/Meta-Llama-3.1-8B-Instruct --output-dir /tmp/Meta-Llama-3.1-8B-Instruct --ignore-patterns "original/consolidated.00.pth" | ||
# | ||
# To launch on 4 devices, run the following command from root: | ||
# tune run --nnodes 1 --nproc_per_node 4 full_dpo_distributed --config llama3_1/8B_full_dpo | ||
# | ||
# You can add specific overrides through the command line. For example | ||
# to override the checkpointer directory while launching training | ||
# you can run: | ||
# tune run --nnodes 1 --nproc_per_node 4 full_dpo_distributed --config llama3_1/8B_full_dpo checkpointer.checkpoint_dir=<YOUR_CHECKPOINT_DIR> | ||
# | ||
# This config works best when the model is being fine-tuned on 2+ GPUs. | ||
# For single device full DPO alignment please use llama3_1/8B_full_dpo_single_device | ||
|
||
output_dir: /tmp/torchtune/llama3_1_8B/full_dpo # /tmp may be deleted by your system. Change it to your preference. | ||
|
||
# Model Arguments | ||
model: | ||
_component_: torchtune.models.llama3_1.llama3_1_8b | ||
|
||
# Tokenizer | ||
tokenizer: | ||
_component_: torchtune.models.llama3.llama3_tokenizer | ||
path: /tmp/Meta-Llama-3.1-8B-Instruct/original/tokenizer.model | ||
max_seq_len: 1024 # higher increases memory | ||
|
||
checkpointer: | ||
_component_: torchtune.training.FullModelHFCheckpointer | ||
checkpoint_dir: /tmp/Meta-Llama-3.1-8B-Instruct/ | ||
checkpoint_files: [ | ||
model-00001-of-00004.safetensors, | ||
model-00002-of-00004.safetensors, | ||
model-00003-of-00004.safetensors, | ||
model-00004-of-00004.safetensors | ||
] | ||
recipe_checkpoint: null | ||
output_dir: ${output_dir} | ||
model_type: LLAMA3 | ||
resume_from_checkpoint: False | ||
|
||
ref_checkpointer: | ||
_component_: torchtune.training.FullModelHFCheckpointer | ||
checkpoint_dir: /tmp/Meta-Llama-3.1-8B-Instruct/ | ||
checkpoint_files: [ | ||
model-00001-of-00004.safetensors, | ||
model-00002-of-00004.safetensors, | ||
model-00003-of-00004.safetensors, | ||
model-00004-of-00004.safetensors | ||
] | ||
recipe_checkpoint: null | ||
output_dir: ${output_dir} | ||
model_type: LLAMA3 | ||
|
||
# Dataset and Sampler | ||
dataset: | ||
_component_: torchtune.datasets.stack_exchange_paired_dataset | ||
seed: null | ||
shuffle: True | ||
batch_size: 4 | ||
|
||
# Optimizer and Scheduler | ||
optimizer: | ||
_component_: torch.optim.AdamW | ||
fused: True | ||
weight_decay: 0.05 | ||
lr: 1e-6 | ||
lr_scheduler: | ||
_component_: torchtune.training.lr_schedulers.get_cosine_schedule_with_warmup | ||
num_warmup_steps: 100 | ||
|
||
loss: | ||
_component_: torchtune.rlhf.loss.DPOLoss | ||
beta: 0.05 | ||
label_smoothing: 0 | ||
|
||
# Training | ||
epochs: 1 | ||
max_steps_per_epoch: 1000 | ||
gradient_accumulation_steps: 8 # Use to increase effective batch size | ||
compile: False # torch.compile the model + loss, True increases speed + decreases memory | ||
|
||
# Logging | ||
metric_logger: | ||
_component_: torchtune.training.metric_logging.DiskLogger | ||
log_dir: ${output_dir}/logs | ||
log_every_n_steps: 1 | ||
log_peak_memory_stats: True | ||
|
||
# Environment | ||
device: cuda | ||
dtype: bf16 | ||
|
||
# Memory management | ||
enable_activation_checkpointing: True # True reduces memory | ||
enable_activation_offloading: False # True reduces memory |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you mentioned you trained on 2 nodes it'd be good to add the command you used here.
Seperately, I'm going to try see if I can find a config that can train on a single node with reasonable speeds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into running this on 1 node and I couldn't find a way to get it to fit - if you do please feel free to update. Otherwise, maybe it's not worth including this 70B_full_dpo.yaml in the PR since technically I only got this working with some custom scripts using sbatch and torchrun with --nnodes 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I'm late to this discussion, but at least for now I would leave out any config that cannot run on a single node. Now that #2301 is open, we do have a playbook on how to run our recipes on multiple nodes. At the same time, I don't want us to be in the business of maintaining a bunch of separate slurm scripts for every recipe. So the way I would sequence this is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separately, at least for 70B full finetune, we can fit on a single node with CPU offload (see the config
fsdp_cpu_offload
). Not sure if it's sufficient here (or the perf implications). There is also optimizer-in-backward and 8-bit optimizers (maybe model quality implications for the latter though). And while I'm leaving random suggestions.. if we are gonna do a 70B Llama model, why not 3.3?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I removed the 70B config for now! Fair point on using 3.3 - I stuck to 3.1 to keep it simple for now and I hope it could be adapted relatively easily to 3.3.