This repository was archived by the owner on Apr 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 64
Map batch matmul from PT to TVM. #95
Open
kimishpatel
wants to merge
1
commit into
pytorch:master
Choose a base branch
from
kimishpatel:lower_batch_matmul
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinghai
approved these changes
Aug 20, 2019
|
|
||
| auto transpose_attrs = tvm::make_node<tvm::relay::TransposeAttrs>(); | ||
| auto& axes = transpose_attrs->axes; | ||
| axes.push_back(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this specific order?
ea2cdd9 to
2dba17a
Compare
|
Hmm, try rebasing and it should work. |
Also added test. Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
2dba17a to
e598e92
Compare
|
Rebase to master and we should expect CI to pass. |
|
This one is causing some correctness issues when run with bert model, even though unit tests pass. So I need to do some investigation before pushing it in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added test.
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: