Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BC linter #7569

Merged
merged 11 commits into from
May 10, 2023
Merged

Add BC linter #7569

merged 11 commits into from
May 10, 2023

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 9, 2023 •
edited by pytorch-bot bot

@pytorch-bot
Copy link

pytorch-bot bot commented May 9, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7569

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit f15fea0:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@izaitsevfb
Copy link

Yep, should just work.

pmeier
pmeier reviewed May 10, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the file is copy-pasted from core, but I don't see a strong reason why we couldn't put the job into https://github.com/pytorch/vision/blob/main/.github/workflows/lint.yml so we have all the linters in one place. We only need to guard this step to only run on PRs, since we need for parametrizing the action.

.github/workflows/lint-bc.yml Outdated Show resolved Hide resolved
.github/workflows/lint-bc.yml Outdated Show resolved Hide resolved
.github/workflows/lint-bc.yml Outdated Show resolved Hide resolved
.github/workflows/lint-bc.yml Outdated Show resolved Hide resolved
@pmeier
Copy link
Collaborator

pmeier commented May 10, 2023

Runs as expected: https://github.com/pytorch/vision/actions/runs/4935586144/jobs/8822079047?pr=7569

pmeier
pmeier approved these changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat self-approving now. Happy to wait for someoneelses approval. Don't forget to revert e1ce690 before merge.

.github/workflows/lint.yml
runs-on: ubuntu-latest
steps:
- name: Run BC Lint Action
uses: pytorch/test-infra/.github/actions/bc-lint@main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe switch to fixed version here, i.e.

Suggested change
uses: pytorch/test-infra/.github/actions/bc-lint@main
uses: pytorch/test-infra/.github/actions/bc-lint@v20230509-105021

or

Suggested change
uses: pytorch/test-infra/.github/actions/bc-lint@main
uses: pytorch/test-infra/.github/actions/bc-lint@d8944a4b2a96b70f66c3c56d97b93c2c6bc9936a

We are pinning the linter versions for everything else as well to avoid issues coming from upstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO keep main so we can benefits from improvements automatically. If it becomes noisy because of failures we can revisit

@NicolasHug NicolasHug merged commit 078959f into pytorch:main May 10, 2023
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request May 16, 2023
@NicolasHug @facebook-github-bot
[fbsync] Add BC linter (#7569)
01d4358 
Summary: Co-authored-by: Philip Meier <[email protected]>

Reviewed By: vmoens

Differential Revision: D45903815

fbshipit-source-id: 9814bb2968ccf427d5150b0099a202eeeda5f52d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaitsevfb izaitsevfb izaitsevfb left review comments

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed code quality enhancement module: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NicolasHug @izaitsevfb @pmeier @facebook-github-bot