-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BC linter #7569
Add BC linter #7569
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7569
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New FailuresAs of commit f15fea0: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Yep, should just work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the file is copy-pasted from core, but I don't see a strong reason why we couldn't put the job into https://github.com/pytorch/vision/blob/main/.github/workflows/lint.yml so we have all the linters in one place. We only need to guard this step to only run on PRs, since we need for parametrizing the action.
Co-authored-by: Philip Meier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat self-approving now. Happy to wait for someoneelses approval. Don't forget to revert e1ce690 before merge.
runs-on: ubuntu-latest | ||
steps: | ||
- name: Run BC Lint Action | ||
uses: pytorch/test-infra/.github/actions/bc-lint@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe switch to fixed version here, i.e.
uses: pytorch/test-infra/.github/actions/bc-lint@main | |
uses: pytorch/test-infra/.github/actions/bc-lint@v20230509-105021 |
or
uses: pytorch/test-infra/.github/actions/bc-lint@main | |
uses: pytorch/test-infra/.github/actions/bc-lint@d8944a4b2a96b70f66c3c56d97b93c2c6bc9936a |
We are pinning the linter versions for everything else as well to avoid issues coming from upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO keep main so we can benefits from improvements automatically. If it becomes noisy because of failures we can revisit
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: Co-authored-by: Philip Meier <[email protected]> Reviewed By: vmoens Differential Revision: D45903815 fbshipit-source-id: 9814bb2968ccf427d5150b0099a202eeeda5f52d
Add BC linter
I just copy pasted https://github.com/pytorch/pytorch/blob/main/.github/workflows/lint-bc.yml as is, hopefully it just works?
cc @seemethere