Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the confusing example of gt_pred_pairs_of_highest_quality #7730

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

fansuregrin
Copy link
Contributor

Correct the example of gt_pred_pairs_of_highest_quality. torch.where(condition) is identical to torch.nonzero(condition, as_tuple=True). So the gt_pred_pairs_of_highest_quality is a tuple of LongTensor.

Correct the example of `gt_pred_pairs_of_highest_quality`. `torch.where(condition)` is identical to `torch.nonzero(condition, as_tuple=True)`. So the `gt_pred_pairs_of_highest_quality` is a tuple of LongTensor.
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 10, 2023

@facebook-github-bot
Copy link

Hi @fansuregrin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@fansuregrin fansuregrin changed the title Update _utils.py Fix the confusing example of gt_pred_pairs_of_highest_quality Jul 10, 2023
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @fansuregrin . The changes look good but I suspect there will be formatting issues (see suggestion below). Thanks!

torchvision/models/detection/_utils.py Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@NicolasHug NicolasHug merged commit 29418e3 into pytorch:main Jul 14, 2023
39 of 60 checks passed
@NicolasHug
Copy link
Member

Thank you @fansuregrin , merged!

@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@fansuregrin fansuregrin deleted the patch-1 branch July 14, 2023 12:11
facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
…ty` (#7730)

Reviewed By: matteobettini

Differential Revision: D48642244

fbshipit-source-id: 9a08924684da466b44c5043e7dec2cdff9e7dc4d

Co-authored-by: Nicolas Hug <[email protected]>
Co-authored-by: Nicolas Hug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants