Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to gallery #7883

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Improvements to gallery #7883

merged 3 commits into from
Aug 25, 2023

Conversation

NicolasHug
Copy link
Member

This does a few things:

  • Rename the gallery/v2_transforms into just gallery/transforms. I'll be moving all tranforms-related examples there soon.
  • Rename the example names to remove the "v2" part. There's no need to have "v2" in those. Ideally we avoid renaming examples because this may break hard html links, but in our case this doesn't matter because we are breaking all links already anyway since we have moved all the examples in the [v2]_transforms or others subsections.
  • Hard-code an order for the examples to have the entry-level ones first, and the advanced ones last.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 25, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7883

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 1013a2a with merge base 224cbc8 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 09:59 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 09:59 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 09:59 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 09:59 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 09:59 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 09:59 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 09:59 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 09:59 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 09:59 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 09:59 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 09:59 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:00 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:00 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:00 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:00 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:00 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:00 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:00 — with GitHub Actions Inactive
NicolasHug
NicolasHug commented Aug 25, 2023
View reviewed changes
docs/source/conf.py Outdated
@@ -75,15 +75,37 @@

"""

from sphinx_gallery.sorting import _SortKey
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Private, but if this is ever an issue I think it wil be very easily resolved. Alternatively I can just write the __init__ in our CustomGalleryExampleSortKey

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this will only be two lines, I think we can safely inline it.

pmeier
pmeier approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after #7883 (comment). Thanks Nicolas!

@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:30 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:31 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:31 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:31 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:31 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:31 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:40 — with GitHub Actions Inactive
@NicolasHug NicolasHug temporarily deployed to pytorchbot-env August 25, 2023 10:46 — with GitHub Actions Inactive
@NicolasHug NicolasHug merged commit 7ebc3ad into pytorch:main Aug 25, 2023
57 of 63 checks passed
facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2023
@NicolasHug @facebook-github-bot
[fbsync] Improvements to gallery (#7883)
19ef3eb 
Summary: (Note: this ignores all push blocking failures!)

Reviewed By: matteobettini

Differential Revision: D48900413

fbshipit-source-id: 5a1d207bdb5a6676690c1006a9dae6c4a245f94d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed enhancement module: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasHug @pmeier @facebook-github-bot