-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to gallery #7883
Improvements to gallery #7883
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7883
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New FailuresAs of commit 1013a2a with merge base 224cbc8 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
docs/source/conf.py
Outdated
@@ -75,15 +75,37 @@ | |||
|
|||
""" | |||
|
|||
from sphinx_gallery.sorting import _SortKey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Private, but if this is ever an issue I think it wil be very easily resolved. Alternatively I can just write the __init__
in our CustomGalleryExampleSortKey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this will only be two lines, I think we can safely inline it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after #7883 (comment). Thanks Nicolas!
Summary: (Note: this ignores all push blocking failures!) Reviewed By: matteobettini Differential Revision: D48900413 fbshipit-source-id: 5a1d207bdb5a6676690c1006a9dae6c4a245f94d
This does a few things:
gallery/v2_transforms
into justgallery/transforms
. I'll be moving all tranforms-related examples there soon.[v2]_transforms
orothers
subsections.