-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve affine bounding box reference helper #7884
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7884
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit f497a9e with merge base fae5321 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
# Estimate meta-data for image with inverted=True | ||
affine_vector = _get_inverse_affine_matrix(center, angle, translate, scale, shear) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #7723 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although it is a bit complicated to trace all edge cases this updates can bring.
Let's on the CI
After trying to use the new helper for Thus, point 3. in #7884 (comment) now changes to
Point 1. and 2. are still valid. |
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: (Note: this ignores all push blocking failures!) Reviewed By: matteobettini Differential Revision: D48900391 fbshipit-source-id: 1d28073ec3059ff6815e9d7cdf5c3ea054acd71f
Improvements for
reference_affine_bounding_boxes_helper
:datapoints.BoundingBoxes
directly rather than atorch.Tensor
with explicit metadatadatapoints.BoundingBoxes
expand=True
, which is needed for the bounding box correctness tests ofF.rotate
andF.resize
cc @vfdev-5