Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sigma input type for v2.GaussianBlur #7887

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Aug 25, 2023

Fixes #7885

Description:

  • Fixed int type support in v2.GaussianBlur sigma arg
  • Added tests

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 25, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7887

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Pending, 1 Unrelated Failure

As of commit 2086d2e with merge base a2f8f8e (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 12:10 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 requested a review from pmeier August 25, 2023 12:24
test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved
test/test_transforms_v2.py Outdated Show resolved Hide resolved
torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved
torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 13:48 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 13:48 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 13:48 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 13:48 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 13:48 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 13:48 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 13:48 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 15:12 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 15:12 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 15:12 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 15:12 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 15:12 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 15:12 — with GitHub Actions Inactive
@vfdev-5 vfdev-5 temporarily deployed to pytorchbot-env August 25, 2023 15:12 — with GitHub Actions Inactive
torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved
torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tests are failing, this should hopefully fix a few

torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved
torchvision/transforms/v2/_misc.py Outdated Show resolved Hide resolved
torchvision/transforms/v2/_geometry.py Outdated Show resolved Hide resolved
torchvision/transforms/v2/_utils.py Outdated Show resolved Hide resolved
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when green, thanks

@NicolasHug NicolasHug merged commit f1b4c7a into main Aug 30, 2023
58 of 63 checks passed
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@huydhn
Copy link
Contributor

huydhn commented Aug 30, 2023

@NicolasHug @vfdev-5 I'm creating a release branch for vision and notice these 2 failures coming from this change:

error: more than one operator "=" matches these operands:
             function "__half::operator=(float)"
ERROR test/test_transforms_v2_refactored.py::TestGaussianBlur::test_transform[sigma1-cuda-make_video] - RuntimeError: CUDA error: device-side assert triggered

Could you help take a look to address them as soon as you could? The other option would probably be to revert this change to unblock the release

cc @atalman @osalpekar

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Aug 30, 2023

@huydhn first failure is unrelated to this PR as happens during the compilation of roi_pool_kernel.cu:
https://github.com/pytorch/vision/actions/runs/6028057291/job/16360484798#step:11:1405

Same for the second failure as according to logs: https://pipelines.actions.githubusercontent.com/serviceHosts/e1cea170-7cad-4fd4-b94c-3e3f4452f685/_apis/pipelines/1/runs/79880/signedlogcontent/12?urlExpires=2023-08-30T21%3A39%3A38.2279569Z&urlSigningMethod=HMACV1&urlSignature=tOpOBPfJVdDJ1jlYYVPow%2FHRlZRU5YmKqd9hMbUySEE%3D

It starts failing with

2023-08-30T19:22:26.6144348Z ==================================== ERRORS ====================================
2023-08-30T19:22:26.6144773Z �[31m�[1m____ ERROR at teardown of test_detection_model[cuda-retinanet_resnet50_fpn] ____�[0m
2023-08-30T19:22:26.6145147Z �[1m�[31mtest/conftest.py�[0m:120: in prevent_leaking_rng
2023-08-30T19:22:26.6145438Z     torch.cuda.set_rng_state(cuda_rng_state)
2023-08-30T19:22:26.6145882Z �[1m�[31m/opt/conda/envs/ci/lib/python3.8/site-packages/torch/cuda/random.py�[0m:64: in set_rng_state
2023-08-30T19:22:26.6146234Z     _lazy_call(cb)
2023-08-30T19:22:26.6146734Z �[1m�[31m/opt/conda/envs/ci/lib/python3.8/site-packages/torch/cuda/__init__.py�[0m:183: in _lazy_call
2023-08-30T19:22:26.6147103Z     callable()
2023-08-30T19:22:26.6147543Z �[1m�[31m/opt/conda/envs/ci/lib/python3.8/site-packages/torch/cuda/random.py�[0m:62: in cb
2023-08-30T19:22:26.6147942Z     default_generator.set_state(new_state_copy)
2023-08-30T19:22:26.6148326Z �[1m�[31mE   RuntimeError: CUDA error: device-side assert triggered�[0m
2023-08-30T19:22:26.6148817Z �[1m�[31mE   CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.�[0m
2023-08-30T19:22:26.6149313Z �[1m�[31mE   For debugging consider passing CUDA_LAUNCH_BLOCKING=1.�[0m
2023-08-30T19:22:26.6149854Z �[1m�[31mE   Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.�[0m
2023-08-30T19:22:26.6150332Z ----------------------------- Captured stderr call -----------------------------

none of further CUDA tests is passing.

@huydhn
Copy link
Contributor

huydhn commented Aug 30, 2023

Let me retry these job one more time. Something else is probably causing these failures then and they are indeed pasing again in the latest vision commit https://hud.pytorch.org/hud/pytorch/vision/main

facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2023
Reviewed By: matteobettini

Differential Revision: D48900377

fbshipit-source-id: 72b40e1fd390214714d1a964ca3d4373db9bde34

Co-authored-by: Philip Meier <[email protected]>
Co-authored-by: Nicolas Hug <[email protected]>
@vfdev-5 vfdev-5 deleted the fix-7885-gaussian-blur branch September 7, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.GaussianBlur doesn't support ints
5 participants