Datapoint -> TVTensor; datapoint[s] -> tv_tensor[s] #7894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7894
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 4 Unrelated FailuresAs of commit e6e37bb with merge base b9447fd ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
commented
Aug 29, 2023
gallery/others/plot_video_api.py
Outdated
| @@ -86,7 +86,7 @@ | |||
| print("PTS for first five frames ", ptss[:5]) | |||
| print("Total number of frames: ", len(frames)) | |||
| approx_nf = metadata['audio']['duration'][0] * metadata['audio']['framerate'][0] | |||
| print("Approx total number of datapoints we can expect: ", approx_nf) | |||
| print("Approx total number of tv_tensors we can expect: ", approx_nf) | |||
NicolasHug
commented
Aug 29, 2023
| dispatch their inputs to the appropriate lower-level kernels. Most users do not | ||
| need to manipulate datapoints directly and can simply rely on dataset wrapping - | ||
| need to manipulate tv_tensors directly and can simply rely on dataset wrapping - |
There was a problem hiding this comment.
Occurrences like this "tv_tensor" one should probably become "TVTensor". But this can be done in a follow-up PR that cleans the docs
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
Summary: (Note: this ignores all push blocking failures!) Reviewed By: matteobettini Differential Revision: D48900381 fbshipit-source-id: 86f83471c658acc2d514dc0f900dfd33c51be370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #7895
cc @vfdev-5