Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put back disable_beta_transforms_warning and make it a noop #7897

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Put back disable_beta_transforms_warning and make it a noop #7897

merged 2 commits into from
Aug 29, 2023

Conversation

NicolasHug
Copy link
Member

Fix #7896

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 29, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7897

Note: Links to docs will display an error until the docs builds have been completed.

❌ 31 New Failures, 1 Unrelated Failure

As of commit 1244f27 with merge base ec881a0 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug
NicolasHug commented Aug 29, 2023
View reviewed changes
torchvision/__init__.py
def disable_beta_transforms_warning():
# Noop, only exists to avoid breaking existing code.
# See https://github.com/pytorch/vision/issues/7896
pass
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we'll want to raise a warning here to remove this eventually, but it's probably not worth it

pmeier
pmeier approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NicolasHug NicolasHug merged commit e928537 into pytorch:main Aug 29, 2023
9 of 20 checks passed
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug added the other if you have no clue or if you will manually handle the PR in the release notes label Aug 29, 2023
facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2023
@NicolasHug @facebook-github-bot
[fbsync] Put back disable_beta_transforms_warning and make it a noop (#…
c201717 
…7897)

Summary: (Note: this ignores all push blocking failures!)

Reviewed By: matteobettini

Differential Revision: D48900409

fbshipit-source-id: 67646ec2775059971e8b499039ed03721c3abf47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

Assignees
No one assigned
Labels
cla signed other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put back disable_beta_transforms_warning and make it a no-op
3 participants
@NicolasHug @pmeier @facebook-github-bot