Skip to content

Conversation

@morrison-turnansky
Copy link
Contributor

@morrison-turnansky morrison-turnansky commented Aug 26, 2025

Fixes Issue pytorch/pytorch#161509
updated install command in cpp debugger md.

Copy link
Collaborator

@zhanyong-wan zhanyong-wan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one suggestion...

@morrison-turnansky
Copy link
Contributor Author

@mikegre-google @qihqi Please let me know if you would like any additional changes.

@morrison-turnansky
Copy link
Contributor Author

Sorry to ping you again, @mikegre-google @qihqi can you please take a look when you get a chance, thank you.

@ysiraichi
Copy link
Collaborator

Not sure why the checks aren't running. Could you try rebasing it to re-trigger the checks?

@morrison-turnansky
Copy link
Contributor Author

@ysiraichi The current command is an outdated install command for pytorch. The command in the change is now the recommended install command from pytorch. See https://github.com/pytorch/pytorch?tab=readme-ov-file#installation

@qihqi qihqi enabled auto-merge (squash) November 13, 2025 23:41
@qihqi qihqi disabled auto-merge November 13, 2025 23:41
@qihqi qihqi merged commit 329c2e7 into pytorch:master Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants