feat: make JAX optional with env variable control #9615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qihqi
approved these changes
Sep 4, 2025
|
Rebasing to HEAD might fix the build issue. |
qihqi
reviewed
Sep 9, 2025
| jax.config.update('jax_use_shardy_partitioner', False) | ||
| return jax | ||
| except (ModuleNotFoundError, ImportError): | ||
| logging.warn('You are trying to use a feature that requires jax/pallas.' |
There was a problem hiding this comment.
Let's do something simpler.
Instead of the env variable, just remove this logging.
There was a problem hiding this comment.
We can probably fix the test if that's a concern? Or do you see some other issue?
There was a problem hiding this comment.
just the tests. Although I don't need the logging in this function, so it can be simplified if so.
i.e. it's reasonable to push the logging to the callsites of maybe_get_jax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9569
Changes: