Repository navigation
Narrow the transform validators' catch-all return types - #43
Merged
Merged
Conversation
`validate_transform4x4` always returns a floating array, and `validate_transform3x3` and `validate_rotation` return a real one; all three reject booleans. Their `TransformLike`/`RotationLike` overloads returned `_Array2D[_Scalar]`, which includes `np.bool_` and, for the 4x4 case, integers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 11 11
Lines 1169 1169
Branches 135 135
=======================================
Hits 1166 1166
Misses 1 1
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_transform4x4always returns a floating array, andvalidate_transform3x3andvalidate_rotationreturn a real one; all three reject booleans. TheirTransformLikeandRotationLikeoverloads returned_Array2D[_Scalar], which includesnp.bool_and, for the 4x4 validator, integers, so callers had to cast results they use as floats.validate_transform4x4catch-all returns_Array2D[_Floating].validate_transform3x3andvalidate_rotationcatch-alls return_Array2D[_Real].Changes drafted by Claude Opus 5.5 but fully understood by me.
🤖 Generated with Claude Code (Claude Opus 5.5)