Repository navigation
Conversation
`pyvista_validation.config` has one boolean switch per kind of check, named after its check function, plus `enabled` for all of them and `axes` and `rotation` for the geometric checks of `validate_axes` and `validate_rotation`. A switched-off check returns its input unchanged, in its `check` function and in the `validate` options that use it; casts, reshapes and dtype conversions always run. `config.override(...)` sets switches for a `with` block, and `PYVISTA_VALIDATION_CHECKS=false` starts with `enabled` off. The C fast paths read the same switches as a bitmask. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # pyvista_validation/check.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 99.74% 99.79% +0.05%
==========================================
Files 11 12 +1
Lines 1167 1459 +292
Branches 135 162 +27
==========================================
+ Hits 1164 1456 +292
Misses 1 1
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…d run Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
pyvista_validation.config, which turns the runtime checks off globally (enabled) or one kind at a time: one switch percheck_*function, plusaxesandrotationfor the geometric checks ofvalidate_axesandvalidate_rotation. A switched-off check returns its input unchanged, both in itscheckfunction and in thevalidate_arrayoptions that use it; casts, reshapes and dtype conversions always run, so valid input gives the same output.config.override(...)scopes switches to awithblock, andPYVISTA_VALIDATION_CHECKS=falsestarts withenabledoff.The C fast paths read the same switches as a bitmask. Composite checks such as
check_nonnegativeandcheck_stringcall private helpers, so only their own switch applies.to_dict/from_dictare there for a futurepyvista.global_config.validation.checkssection.validate_arrayNx3, 1M x 3, finitecheck_sorted, 1MTimed with
timeiton an M-series MacBook, best of 5.Changes drafted by Claude Opus 5.5 but fully understood by me.
🤖 Generated with Claude Code (Claude Opus 5.5)