Skip to content

Commit

Permalink
fix(container_window): remove createWindowContainer
Browse files Browse the repository at this point in the history
Having `createWindowContainer` in `QVTKRenderWindowInteractor` is
causing segfaults. Instead, teach users to add

```python
window_ = QtGui.QWindow.fromWinId(self.plotter.winId())
self.container = self.createWindowContainer(window_, self)
```

to their `MainWindow` class.
  • Loading branch information
adamgranthendry committed Jul 16, 2022
1 parent bebabe5 commit 5b138c9
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions pyvistaqt/plotting.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
from pyvista.plotting.plotting import BasePlotter
from pyvista.plotting.render_window_interactor import RenderWindowInteractor
from pyvista.utilities import conditional_decorator, threaded
from qtpy import QtCore
from qtpy import QtCore, QtWidgets
from qtpy.QtCore import QSize, QTimer, Signal
from qtpy.QtWidgets import (
QAction,
Expand Down Expand Up @@ -270,9 +270,6 @@ def __init__(
self._first_time = False # Crucial!
LOG.debug("QtInteractor init stop")

window_ = QtGui.QWindow.fromWinId(self.winId())
self.createWindowContainer(window_, self)

def _setup_interactor(self, off_screen: bool) -> None:
if off_screen:
self.iren: Any = None
Expand Down

0 comments on commit 5b138c9

Please sign in to comment.