Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP,ENH: MultiPlotter improvements #90

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Mar 11, 2021

This PR adds a margin parameter to the MultiPlotter:

margin=True margin=False
image image
import pyvista as pv
from pyvistaqt import MultiPlotter

mp = MultiPlotter(nrows=2, ncols=2, menu_bar=False, toolbar=False, margin=False)
mp[0, 0].add_mesh(pv.Sphere())
mp[0, 1].add_mesh(pv.Cylinder())
mp[1, 0].add_mesh(pv.Cube())
mp[1, 1].add_mesh(pv.Cone())

ToDo:

  • Testing/Coverage

@GuillaumeFavelier GuillaumeFavelier added the enhancement New feature or request label Mar 11, 2021
@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #90 (791cbf0) into main (7157bbb) will decrease coverage by 0.06%.
The diff coverage is 97.56%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   97.22%   97.15%   -0.07%     
==========================================
  Files           8        8              
  Lines         648      669      +21     
  Branches       90       95       +5     
==========================================
+ Hits          630      650      +20     
- Partials       18       19       +1     

@GuillaumeFavelier GuillaumeFavelier changed the title WIP,ENH: MultiPlotter margin ENH: MultiPlotter margin Mar 11, 2021
@GuillaumeFavelier
Copy link
Contributor Author

Custom margin would be interesting to have? If not, it's ready to go on my end.

@GuillaumeFavelier GuillaumeFavelier marked this pull request as ready for review March 12, 2021 11:29
@GuillaumeFavelier
Copy link
Contributor Author

GuillaumeFavelier commented Mar 18, 2021

I'll continue working on this :)

@GuillaumeFavelier GuillaumeFavelier changed the title ENH: MultiPlotter margin WIP,ENH: MultiPlotter improvements Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants