Expedite removal convention parameter in from/to_euler() methods #446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR changes the planned removal of the
convention
parameter in the class methods to convert between quaternions and Euler angles to v0.13, in two minor releases. The original plan was to remove it in v1.0, but there are many kinks left to iron out before that, so I suggest to remove it in v0.13 as it was deprecated since v0.9.I've made some other minor changes to wording and simplified some code in the docs as well.
These changes were originally added in for #442, but since that PR has to wait, I've made this PR instead.
Progress of the PR
Minimal example of the bug fix or new feature
See the docs built from this PR: https://orix--446.org.readthedocs.build/en/446/changelog.html.
For reviewers
__init__.py
.section in
CHANGELOG.rst
.__credits__
inorix/__init__.py
and in.zenodo.json
.