Feature/colourscheme #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not entirely sure why it keeps hanging on those two commits when I open a PR...? |
Try rebasing your branch against my main. |
- This introduces a new colours package. It's intended to store all of the colour definitions used in the application. - This is still WIP, the thoughts behind this is to refactor some of the hard coded colour codes into named literals. This could lead to users defining their own colourschemes/setting which colours should be used for which sort of text. Another possible addition are themes. - Thoughts would be to then have another packge named themes?
DMunkei
force-pushed
the
feature/colourscheme
branch
from
417448d to
c8bc222
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't ready to be merged in yet.
This introduces a new colours package. It's intended to store all of
the colour definitions used in the application.
This is still WIP, the thoughts behind this is to refactor some of the
hard coded colour codes into named literals. This could lead to users
defining their own colourschemes/setting which colours should be used
for which sort of text. Another possible addition are themes.
Thoughts would be to then have another package named themes?
If you think this might be nice addition I could try and flesh it out a bit further.