Skip to content

Conversation

Now-Shimmer
Copy link
Contributor

PR Details

Add formula function BAHTTEXT support

Description

Add formula function BAHTTEXT support

Related Issue

Add formula function BAHTTEXT support

Motivation and Context

Add formula function BAHTTEXT support

How Has This Been Tested

Add unit test for my changes.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@peng peng added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 11, 2025
@Now-Shimmer
Copy link
Contributor Author

Hi @peng, I fixed code review issue, please take a review. Thanks!

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 11.22449% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.96%. Comparing base (9e0c94e) to head (b19ac02).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
calc.go 11.22% 86 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2187      +/-   ##
==========================================
- Coverage   99.24%   98.96%   -0.29%     
==========================================
  Files          32       32              
  Lines       30626    30724      +98     
==========================================
+ Hits        30395    30406      +11     
- Misses        153      239      +86     
- Partials       78       79       +1     
Flag Coverage Δ
unittests 98.96% <11.22%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peng peng added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2025
Copy link
Collaborator

@peng peng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks for your contribution.

@peng peng merged commit c95ba17 into qax-os:master Sep 4, 2025
15 of 17 checks passed
@xuri xuri moved this to Features in Excelize v2.10.0 Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Features
Development

Successfully merging this pull request may close these issues.

2 participants