Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly fix the Onesync Spectate Issue Mentioned in Issue #137 #171

Closed
wants to merge 7 commits into from

Conversation

amantu-qbit
Copy link
Contributor

Added Requested Collision Before the TP. Should Stick the Spectate with eh person which nullifies the problem we face with one sync. And it might fix the issue mentioned in #137 . I don't have a player base to test. Would be nice if anyone could try and give me feedback.

@sinphoenix
Copy link

I tested with one person. I will do another test today with more people to ensure it works.

@kokorog
Copy link

kokorog commented Aug 28, 2022

dont work for me

@Linden-Dev
Copy link

Linden-Dev commented Feb 2, 2023

So it works if you're within range of the player (e.g. you have them loaded), but as soon as they're at a distance this fails

@GodyFromDiscord
Copy link

PR Outdated from main, will test soon.

@GodyFromDiscord
Copy link

Thank you, will test shortly and feedback to the team

Added get ped from server side incase of OneSync Related loading issue where ped don't get where the player is.

Added Copy Vector2 Button.
@amantu-qbit
Copy link
Contributor Author

Thank you, will test shortly and feedback to the team

Thank you. Did some changes without being tested would greatly appreciate it if can get feedback!

locales/en.lua Outdated
@@ -15,6 +15,7 @@ local Translations = {
["failed_set_speed"] = "You did not set a speed.. (`fast` for super-run, `normal` for normal)",
["failed_set_model"] = "You did not set a model..",
["failed_entity_copy"] = "No freeaim entity info to copy to clipboard!",
["no_player"] = 'Player Doesn\'t exist in server anymore',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewing and testing in game at the moment, but for the sake of grammar, if you don't make making 'Doesn't' to 'doesn't'

@@ -1141,6 +1148,10 @@ RegisterNetEvent('qb-admin:client:ToggleCoords', function()
ToggleShowCoordinates()
end)

menu7_dev_copy_vec2:On("select", function()
CopyToClipboard('coords2')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all works fine and looks good to me

Copy link

@GodyFromDiscord GodyFromDiscord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just testing the spectate function now but I have also requested a tiny grammar change

@GodyFromDiscord
Copy link

Upon spectating the player you contiously fall through the ground and it does not spectate them, this happens at a distance only, but when within a close range of the player, the spectate works fine

@amantu-qbit
Copy link
Contributor Author

Upon spectating the player you continuously fall through the ground and it does not spectate them, this happens at a distance only, but when within a close range of the player, the spectate works fine

Thank you for the info. May I know apprx distance?

@GodyFromDiscord
Copy link

Upon spectating the player you continuously fall through the ground and it does not spectate them, this happens at a distance only, but when within a close range of the player, the spectate works fine

Thank you for the info. May I know apprx distance?

I will create a video, one moment

@amantu-qbit
Copy link
Contributor Author

https://medal.tv/games/gta-v/clips/17WykA4Rlw1_pH/d1337SMnVVKv?invite=cr-MSw3WTMsNjI2NTgyMSw

Video ^

Thanks for the vid. Appreciate it!

meanwhile Did an update can you try?

@GodyFromDiscord
Copy link

https://medal.tv/games/gta-v/clips/17WykA4Rlw1_pH/d1337SMnVVKv?invite=cr-MSw3WTMsNjI2NTgyMSw
Video ^

Thanks for the vid. Appreciate it!

meanwhile Did an update can you try?

Still facing the same issue as before with the latest push made

@ChristianBDev
Copy link

https://medal.tv/games/gta-v/clips/17WykA4Rlw1_pH/d1337SMnVVKv?invite=cr-MSw3WTMsNjI2NTgyMSw
Video ^

Thanks for the vid. Appreciate it!
meanwhile Did an update can you try?

Still facing the same issue as before with the latest push made

@amantu-qbit

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

This PR has had 60 days of inactivity & will close within 7 days

@github-actions github-actions bot added the Stale label Oct 3, 2023
@amantu-qbit amantu-qbit closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants