Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Show correct names above players head #218

Closed
wants to merge 1 commit into from

Conversation

v42-Josh
Copy link

Describe Pull request
Show names are showing other names above people's head, this is an small bug.

If the player is too far away to get the server id it returns -1. If you use -1 on getplayerped then it returns your ped, that is changing your name and ID to show someone else's. With one simple line we can fix it,

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality?
    Yes.
  • Does your code fit the style guidelines?
    Yes
  • Does your PR fit the contribution guidelines?
    Yes

@GhzGarage
Copy link
Member

What did you change? Can't tell

@GhzGarage GhzGarage self-assigned this Jan 8, 2024
@GhzGarage GhzGarage added the question Further information is requested label Jan 8, 2024
@v42-Josh
Copy link
Author

v42-Josh commented Jan 8, 2024

Added the line if playeridx ~= -1 then on line 41.

If the player is too far away to get the server id it returns -1. If you use -1 on getplayerped then it returns your own ped.

Copy link

github-actions bot commented Mar 9, 2024

This PR has had 60 days of inactivity & will close within 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested Stale Closed Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants