🔑 Optionally save acquired keys into DB

[Cocodrulo]

Describe Pull request
This PR makes so the aquired keys will be saved into DB so when the server restarts you will still have the keys you were given. This feature is optional and can be set in the Config file. The PR is made to answer this suggestion [SUGGESTION] Database keys. I believe that is easier to make this into player metadata instead of a full new database table. Also this PR was already open, but also closed because of lack of answer, so I decided to make a new one: old one here.

Questions (please complete the following information):

• Have you personally loaded this code into an updated qbcore project and checked all it's functionality? Yes
• Does your code fit the style guidelines? Yes
• Does your PR fit the contribution guidelines? Yes

[Qwerty1Verified]

Instead of doing it from the client, handle it on the server since to give someone keys the server event gets triggered which also checks if they should be giving keys.

I'd also probably change the config value to be more something like Config.PersistentKeys although others might disagree. I'll ask others.

[Z3rio]

Quoted from my comment left Apr 18 in your past PR for this, #255.
Which for that matter, is exactly the same as this PR.

Lovely PR, and great idea.
But doing it this way is not recommended, as anyone could trigger that server event from their client with any kind of key list.

This should be something to be fully handled on the serverside if it should be secure, qb-core already has enough insecure server events as it is.

Also this PR was already open, but also closed because of lack of answer

Yes indeed, from your side though...
So opening an PR with the exact same files/changes will probably just generate the same result.

[Z3rio]

If you want pointers on how to improve it, I'll gladly assist

[Cocodrulo]

This changes should do the trick

[Z3rio]

Overall great, much better approach this time! 👍🏼 🚀

Some of these "comments" might be a bit nitpicky, other ones quite blatant/more important.
Do as you wish with my feedback. Great work this far!

[Z3rio]

Suggested change

	if not Player then return false end
	if not Player then
	return false
	end

better readability

[Cocodrulo]

I think is better to keep it one line, it's cleaner from my view

[Z3rio]

Suggested change

	if not Player then return end
	if not Player then
	return
	end

better readability

[Cocodrulo]

I think is better to keep it one line, it's cleaner from my view

[Cocodrulo]

Thanks for the ideas and corrections, comments like that are always welcome

[Cocodrulo]

if this going to be added?