Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double click in webui stops/starts torrents , can that be changed ? #20436

Open
rezad1393 opened this issue Feb 18, 2024 · 13 comments · May be fixed by #21000
Open

double click in webui stops/starts torrents , can that be changed ? #20436

rezad1393 opened this issue Feb 18, 2024 · 13 comments · May be fixed by #21000
Labels
Feature request Waiting web implementation A feature implemented in the GUI that requires a Web UI/API implementation WebUI WebUI-related issues/changes

Comments

@rezad1393
Copy link

Suggestion

allow user to change double click behavior for webui.

Use case

when I double click on accident my torrent will stops.
as I have many rare torrents that has no or very low seeds this causes the torrent to be stopped and may not have any more seeds when I start it again.

Extra info/examples/attachments

No response

@luzpaz
Copy link
Contributor

luzpaz commented Feb 18, 2024

Full version info please.

@rezad1393
Copy link
Author

Full version info please.

is there a version that implemented this that I dont have?
usually devs asks for version when user doesnt have the latest version.

but here you go :
qBittorrent v4.6.3 Web UI
on firefox
on linux

@luzpaz luzpaz added the WebUI WebUI-related issues/changes label Mar 24, 2024
@luzpaz
Copy link
Contributor

luzpaz commented Mar 25, 2024

I don't use webui, so i can't test. What are your settings in Preferences > Behavior > Action on Double-click

Screenshot_20240325_082625

Re: Version info should be provided all the time so that if we come back to a ticket we know what version it is referring to. (ATM we have over 2.7K tickets open)

@luzpaz luzpaz added the Waiting info Waiting for participants to supply more info/fulfill template requirements label Mar 25, 2024
@thalieht
Copy link
Contributor

double click in webui stops/starts torrents , can that be changed ?

Nope.

@rezad1393
Copy link
Author

I don't use webui

that is an issue.
those setting you provided are for the gui app.
I user server app (headless) and it doesn't have those setting for webui.

@rezad1393
Copy link
Author

double click in webui stops/starts torrents , can that be changed ?

Nope.

why not?
it helps stop users from accidentally stopping rare torrents that are downloading.

@luzpaz luzpaz added Waiting web implementation A feature implemented in the GUI that requires a Web UI/API implementation and removed Waiting info Waiting for participants to supply more info/fulfill template requirements labels Mar 25, 2024
@luzpaz
Copy link
Contributor

luzpaz commented Mar 25, 2024

Hi @Piccirello, thanks for all the webui related PRs you've made recently. Any chance you'd be interested working on this issue ?

@HanabishiRecca
Copy link
Contributor

The main showstopper here is that we can't make its options on par with the GUI. Options like "Open destination folder" is simply not a thing for the WebUI. It makes the settings (Downloads\DblClOnTorDl & Downloads\DblClOnTorFn) conflict between GUI and WebUI in the config.

We could split it into independent options for the WebUI though. But it could be a bit confusing for users.

@rezad1393
Copy link
Author

The main showstopper here is that we can't make its options on par with the GUI. Options like "Open destination folder" is simply not a thing for the WebUI. It makes the settings (Downloads\DblClOnTorDl & Downloads\DblClOnTorFn) conflict between GUI and WebUI in the config.

We could split it into independent options for the WebUI though. But it could be a bit confusing for users.

maybe I should have worded my request differently.
can this be disable?
webui double clicking stoping a rare torrent that is now downloading from that one peer is a disaster.

@HanabishiRecca
Copy link
Contributor

HanabishiRecca commented Jun 26, 2024

can this be disable?

You already were answered above - no. At the moment, that settings are not implemented for the WebUI and current behavior is simply hardcoded.

My comment above was about technical aspects of potential implementation.


Although, if you are ok with building the app from the source, you could disable it by applying a patch:

--- a/src/webui/www/private/scripts/dynamicTable.js
+++ b/src/webui/www/private/scripts/dynamicTable.js
@@ -1530,18 +1530,6 @@ window.qBittorrent.DynamicTable = (function() {
         },
 
         setupTr: function(tr) {
-            tr.addEvent("dblclick", function(e) {
-                e.stop();
-                this._this.deselectAll();
-                this._this.selectRow(this.rowId);
-                const row = this._this.rows.get(this.rowId);
-                const state = row["full_data"].state;
-                if (state.includes("stopped"))
-                    startFN();
-                else
-                    stopFN();
-                return true;
-            });
             tr.addClass("torrentsTableContextMenuTarget");
         },
 

It simply removes the part that triggers the double click behavior.

P.S. It's for current master branch.

@glassez
Copy link
Member

glassez commented Jun 26, 2024

We could split it into independent options for the WebUI though. But it could be a bit confusing for users.

It is essentially UI related setting, so it isn't a problem in itself if different UIs provide different settings depending from their capabilities.

@HanabishiRecca
Copy link
Contributor

I mean, if settings have exactly identical names, user could imply they should be in sync. But maybe I overthink it really.

@HanabishiRecca
Copy link
Contributor

I attempt to make some implementation for that in #21000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Waiting web implementation A feature implemented in the GUI that requires a Web UI/API implementation WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants