WebUI: Implement double-click behavior controls #21000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HanabishiRecca
force-pushed
the
webui-dblclick
branch
2 times, most recently
from
489347b
to
b79b5e3
Compare
Chocobo1
reviewed
Jun 28, 2024
|
Personally I dislike idea of storing WebUI client settings as regular qBittorrent settings. I would consider any WebUI client (including official one) as separate client application. |
|
I followed existing logic to make this. If you think this settings should be stored in browser local storage instead, I'm not against it. In fact it's even easier that way. |
HanabishiRecca
force-pushed
the
webui-dblclick
branch
from
b79b5e3
to
4191d71
Compare
|
Ok, I made it using local storage. The implementation is very simple now. |
HanabishiRecca
force-pushed
the
webui-dblclick
branch
2 times, most recently
from
ec70553
to
3aa9cee
Compare
Chocobo1
previously approved these changes
Jun 28, 2024
HanabishiRecca
commented
Jun 28, 2024
No idea why. #21007 had the same state back then. |
HanabishiRecca
force-pushed
the
webui-dblclick
branch
from
3aa9cee
to
2a66021
Compare
Chocobo1
approved these changes
Jul 3, 2024
Chocobo1
changed the title
|
@HanabishiRecca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements double-click behavior controls for the WebUI, similar to the desktop GUI.
Closes #20436.
But as I discussed in #20436 (comment), despite the same names, this is not the same settings. Because existing options of the GUI are not applicable for the WebUI, they are implemented as independent standalone settings.
Also the settings implemented as selectors, despite having only 2 options. They actually could be implemented as check boxes instead, but:
Screenshot