Update Changelog #20991
Draft
Update Changelog #20991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glassez
requested changes
Jun 25, 2024
| - BUGFIX: Display error message when unrecoverable error occurred (glassez) | ||
| - BUGFIX: Update size of selected files when selection is changed (glassez) | ||
| - BUGFIX: Normalize tags by trimming leading/trailing whitespace (glassez) | ||
| - BUGFIX: Correctly handle share limits in torrent options dialog (glassez) | ||
| - BUGFIX: Adjust tracker tier when adding additional trackers (Chocobo1) 321d7e5b17b6e4cacf713b4f4409364a5e65873e | ||
| - BUGFIX: Fix inconsistent naming between (Done/Progress) column (luzpaz) d3315f7cc7f31b1578cf72f07b175a80c204dac9 |
There was a problem hiding this comment.
Suggested change
| - BUGFIX: Fix inconsistent naming between (Done/Progress) column (luzpaz) d3315f7cc7f31b1578cf72f07b175a80c204dac9 | |
| - BUGFIX: Fix inconsistent naming between Done/Progress column (luzpaz) d3315f7cc7f31b1578cf72f07b175a80c204dac9 |
| - WEBAPI: Fix wrong timestamp values (Chocobo1) | ||
| - WEBAPI: Send binary data with filename and mime type specified (glassez) | ||
| - WEBAPI: Expose API for the torrent creator (glassez, Radu Carpa) | ||
| - WEBAPI: API for listing directory content (Paweł Kotiuk) a1af077889de587d8c71968a380abc9eb4aea47f |
There was a problem hiding this comment.
Suggested change
| - WEBAPI: API for listing directory content (Paweł Kotiuk) a1af077889de587d8c71968a380abc9eb4aea47f | |
| - WEBAPI: Provide endpoint for listing directory content (Paweł Kotiuk) a1af077889de587d8c71968a380abc9eb4aea47f |
| - WEBAPI: Fix wrong timestamp values (Chocobo1) | ||
| - WEBAPI: Send binary data with filename and mime type specified (glassez) | ||
| - WEBAPI: Expose API for the torrent creator (glassez, Radu Carpa) | ||
| - WEBAPI: API for listing directory content (Paweł Kotiuk) a1af077889de587d8c71968a380abc9eb4aea47f | ||
| - WEBAPI: Provide "isPrivate" flag via "torrents/info" endpoint (ManiMatter) 05416458db79e050f8500e1d543148ce4cf2ecdb |
There was a problem hiding this comment.
Suggested change
| - WEBAPI: Provide "isPrivate" flag via "torrents/info" endpoint (ManiMatter) 05416458db79e050f8500e1d543148ce4cf2ecdb | |
| - WEBAPI: Provide "private" flag via "torrents/info" endpoint (ManiMatter) 05416458db79e050f8500e1d543148ce4cf2ecdb |
| - WEBAPI: API for listing directory content (Paweł Kotiuk) a1af077889de587d8c71968a380abc9eb4aea47f | ||
| - WEBAPI: Provide "isPrivate" flag via "torrents/info" endpoint (ManiMatter) 05416458db79e050f8500e1d543148ce4cf2ecdb | ||
| - WEBAPI: Add a way to download .torrent file using search plugin (glassez) 4d8713ce110d80f995212fb7a779fe16504fb91d | ||
| - WEBAPI: Add "private" filter for 'info' endpoint (ManiMatter) 914728d9a102ee8aa44eb46c413ecb668728709c |
There was a problem hiding this comment.
Suggested change
| - WEBAPI: Add "private" filter for 'info' endpoint (ManiMatter) 914728d9a102ee8aa44eb46c413ecb668728709c | |
| - WEBAPI: Add "private" filter for 'torrents/info' endpoint (ManiMatter) 914728d9a102ee8aa44eb46c413ecb668728709c |
|
c36100f should be mentioned as |
thalieht
reviewed
Jun 25, 2024
| - FEATURE: Focus on Download button if torrent link retrieved from the clipboard (glassez) 7310eec74e6694342e9934ecc524df38d0064bb5 | ||
| - FEATURE: Add ability to pause/resume entire BitTorrent session (glassez) 8ef7d3ec9a56e7445948c37a282629ca5ed551ab | ||
| - FEATURE: Add an option to set BitTorrent session shutdown timeout (glassez) 2b728b3bc0c525905ef4c6086bc45027eb2150fd | ||
| - FEATURE: Apply filename filter to subfolder names as well (glassez) d89f289f82fb6ff4305841c7d4c7899ffe12f896 |
There was a problem hiding this comment.
Suggested change
| - FEATURE: Apply filename filter to subfolder names as well (glassez) d89f289f82fb6ff4305841c7d4c7899ffe12f896 | |
| - FEATURE: Apply "Excluded file names" to folder names as well (glassez) d89f289f82fb6ff4305841c7d4c7899ffe12f896 |
I thought the current description was referring to "Filter files..." in content tab.
| - BUGFIX: Fix inconsistent naming between (Done/Progress) column (luzpaz) d3315f7cc7f31b1578cf72f07b175a80c204dac9 | ||
| - BUGFIX: Sanitize peer client names (Hanabishi) 2c47f09d7a797c1ea886879749b71198e449e701 | ||
| - BUGFIX: Apply share limits when torrent downloading is finished (glassez) 65d143d4c411e045b3cd1cf847dee831290af799 | ||
| - BUGFIX: Revise Protocol column (Chocobo1) 1c49e0973c94b32bf3bfe52845b6b9572c997ef2 |
There was a problem hiding this comment.
No protocol column in 4.6.x so mentioning this is meaningless.
There was a problem hiding this comment.
It's reasonable.
But it is also reasonable to mention fixes from the previous public release of v5.0.x, which is v5.0beta1.
So I would mention all of them in the Changelog, both v5.0beta1 and v5.0RC1, as separate entries, and not just single v5.0. A lot of software do this and it looks good to me.
@sledgehammer999?
There was a problem hiding this comment.
I am thinking of promoting this to a FEATURE entry. "Add 'Protocol' column in trackers tab".
There was a problem hiding this comment.
I am thinking of promoting this to a
FEATUREentry. "Add 'Protocol' column in trackers tab".
It isn't a feature in itself. It is just a side effect of another changes.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the changelog entries for v5 RC1.
I have left the commit hash to ease review.
Also I have taken into account the stuff from PR #20918
PS: This is just for review. After it is approved I'll push it manually, deleting the hashes.