Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom storage when reloading torrent #20998

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

glassez
Copy link
Member

@glassez glassez commented Jun 26, 2024

Unlike libtorrent-2.0 disk IO is customizable on per-torrent basis in libtorrent-1.2, so it should be handled when reloading underlying torrent as well.

@glassez glassez requested a review from a team June 26, 2024 06:27
@glassez glassez added the Core label Jun 26, 2024
Copy link
Contributor

@thalieht thalieht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test. Tried CI for Windows but it silently crashes on startup but so does CI for #20951 so it's probably unrelated.

@xavier2k6
Copy link
Member

xavier2k6 commented Jun 26, 2024

I'll see if I can shed some light on the silent crashes... nope, not experiencing any crashes from either PR.

@thalieht Is it a clean profile/portable or installing on top of a previous release which may have had torrents already added/loaded?

Also see #20951 (comment)

@thalieht

This comment was marked as off-topic.

@xavier2k6

This comment was marked as off-topic.

@thalieht

This comment was marked as off-topic.

@glassez glassez merged commit 0cbe488 into qbittorrent:master Jun 28, 2024
14 checks passed
@glassez glassez deleted the custom-storage branch June 28, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants