Skip to content

Conversation

@glassez
Copy link
Member

@glassez glassez commented Dec 6, 2025

This is a unification and simplification of the management of save paths by removing unnecessary options.
Now the torrent unconditionally follows the base (category) save paths if it is in the automatic management mode. In manual mode, the torrent unconditionally uses the category save paths as base save paths.

In other words, the management mode only affects whether the torrent follows the changes to the base save paths or not.

001

@glassez glassez added this to the 5.2 milestone Dec 6, 2025
@glassez glassez added WebUI WebUI-related issues/changes GUI GUI-related issues/changes Core WebAPI WebAPI-related issues/changes labels Dec 6, 2025
@glassez glassez requested a review from a team December 6, 2025 08:00
@thalieht
Copy link
Contributor

thalieht commented Dec 8, 2025

I'm guessing different people will champion each of these settings for their own reasons.
As for me, i agree with almost everything in this PR (naturally, since i either don't use them or have set them to Relocate).
But i won't feel safe anymore visiting the options in fear of accidentally changing the Default Save Path.

@glassez
Copy link
Member Author

glassez commented Dec 8, 2025

But i won't feel safe anymore visiting the options in fear of accidentally changing the Default Save Path.

If you had it set to Relocate previously nothing is changed for you.
These options were originally intended only so that it would be possible to get the paths from the category when adding a torrent, but not follow it further (that is, the resulting torrents were marked as auto-managed, but actually not). Then "Use category paths in Manual mode" option was added for these purposes. Having all these options at the same time, we get an unjustified logical complication of the code, making it worse maintainable. I've been wanting to get rid of them for a long time, making the logic simpler and clearer, i.e. "auto-managed" torrents follow the changes of category paths, while "manually-managed" not.

@glassez
Copy link
Member Author

glassez commented Dec 8, 2025

But i won't feel safe anymore visiting the options in fear of accidentally changing the Default Save Path.

Of course we can show a message box when Options dialog is accepted with changes that can cause torrents relocation.

@thalieht
Copy link
Contributor

thalieht commented Dec 8, 2025

If you had it set to Relocate previously nothing is changed for you.

Of course i didn't or i wouldn't have mentioned it.

Having all these options at the same time, we get an unjustified logical complication of the code, making it worse maintainable.

I guessed that was the case.

Of course we can show a message box when Options dialog is accepted with changes that can cause torrents relocation.

Sounds good to me 👍

@glassez
Copy link
Member Author

glassez commented Dec 8, 2025

If you had it set to Relocate previously nothing is changed for you.

Of course i didn't or i wouldn't have mentioned it.

As I said, those who had these options set to "Switch to manual mode" did not feel any need to add auto-managed torrents. For some time now, everything they needed has been achieved by "Use category paths in Manual mode" option.

@glassez
Copy link
Member Author

glassez commented Dec 8, 2025

everything they needed has been achieved by "Use category paths in Manual mode" option.

Although it seems to require some refinement at the UI level.
I will take care of this if the direction of these changes is generally approved.

@glassez glassez removed this from the 5.2 milestone Dec 15, 2025
@glassez glassez marked this pull request as draft December 15, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core GUI GUI-related issues/changes WebAPI WebAPI-related issues/changes WebUI WebUI-related issues/changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants