Add macOS semi-native Window menu #23693
Open
+72
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to qbittorrent#23418 Use macos nativ Window menu across Objective-C.
Related to qbittorrent#23418
Related to qbittorrent#23418
kindlaj
changed the title
glassez
reviewed
Jan 3, 2026
glassez
reviewed
Jan 3, 2026
Chocobo1
reviewed
Jan 3, 2026
glassez
reviewed
Jan 3, 2026
Co-authored-by: Vladimir Golovnev <[email protected]>
glassez
reviewed
Jan 4, 2026
src/gui/mainwindow.ui
Outdated
| <addaction name="menuEdit"/> | ||
| <addaction name="menuView"/> | ||
| <addaction name="menuOptions"/> | ||
| <addaction name="menuWindow"/> |
glassez
reviewed
Jan 4, 2026
Co-authored-by: Vladimir Golovnev <[email protected]>
Co-authored-by: Vladimir Golovnev <[email protected]>
glassez
approved these changes
Jan 5, 2026
xavier2k6
approved these changes
Jan 6, 2026
vafada
approved these changes
Jan 7, 2026
Contributor
vafada
left a comment
vafada
left a comment
There was a problem hiding this comment.
Tested and works on my Mac.
Author
|
Which version do you have? |
Contributor
what do you mean? my mac version? Sequoia 15.7.2 |
Author
|
yes-yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23418.
I added Window menu in macOS. It is a semi-native menu item. MacOS fills with some items, but some items we need to add. The menu was add dynamically, because only macOS uses.
I followed the ( Apple Window menu guidline ) and the built-in apps implementations. Like: Safari, Messages, Reminder, Pages, etc...
The following menu items added by manually:
The rest of menu items -which appear in the screenshot- added by macos.
Use the Option key, to change the manual items.
The manually added items have been localized. In the screenshot I changed the system language to Hungarian. Ablak <-> Window.
