WebUI: Enable virtual list support in search tables #23707
Closed
+19
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you make it enabled by default and explicitly disable it for RSS tables? |
Member
Author
It seems likely that #23544 would be merged before we introduce a new table, so I'm not sure it's worth the trouble. |
This is static per-class, so there's no need to pass it during `setup()`.
Member
Author
|
I pushed up an additional change that encapsulates virtual list control directly in the table class. |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables virtual list support in the search results and search plugins tables. The only remaining tables lacking support are the RSS tables, which is being handled in #23544. This PR is much smaller than #23544 and should allow this change to be merged more quickly.
cc @tehcneko in case you'd prefer to keep this as part of your PR