Add build information to the beginning of the binary #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit both htc_9271.fw and htc_7010.fw will have build information in the beginning of the file. Driver can read this information even before loading fw to the chip. Build information format: u32 major; u32 minor; u32 tag; char commit_id[40]; char user_name[32]; Signed-off-by: Eugene Krasnikov <[email protected]>
|
the driver will read the firmware from harddrive , cut build information from the binary and then will send firmware to the dongle already without build information. That's the beauty of this solution;) firmware code is not affected by this change, only build system. |
Closed
|
After this patch https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e904cf6fe23022cde4e0ea9d41601411a315a3dc (kernel v4.4-rc1) we use filename as FW version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit both htc_9271.fw and htc_7010.fw will have build
information in the beginning of the file. Driver can read this
information even before loading fw to the chip.
Build information format:
u32 major;
u32 minor;
u32 tag;
char commit_id[40];
char user_name[32];
Signed-off-by: Eugene Krasnikov [email protected]