Various fixes for package debianization #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the warnings were due to inadapted variable cast during printf. They have been replaced with portable definitions as defined in inttypes.h Signed-off-by: Mathieu Olivari <[email protected]>
Signed-off-by: Mathieu Olivari <[email protected]>
The "install" target currently depends on some virtual target "compile" that never meets the dependency as it doesn't generate a compile file. This change modifies this dependencies and install now depends on $(TOOLS) in each Makefile so that we don't rebuild the binaries if they have already been generated Signed-off-by: Mathieu Olivari <[email protected]>
Signed-off-by: Mathieu Olivari <[email protected]>
This is where "Executable commands and scripts" are support to be according to Debian policy: http://www.debian.org/doc/manuals/maint-guide/dother.en.html#manpage Signed-off-by: Mathieu Olivari <[email protected]>
libkeys.a is a static library therefore it shouldn't be installed in the system as part of the regular "install" rules. There should be a "install-dev" (or so) to install this library together with the header files required for development. For now, we will just remove that installation to remove the lintian warning. Signed-off-by: Mathieu Olivari <[email protected]>
ghost
assigned
razzlefratz
added a commit
that referenced
this pull request
May 7, 2013
…eb43ad2a5d690 Various fixes for package debianization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here are a bunch of changes I did in order to fix various warnings and create a debian package that passes Lintian without too much errors.
I didn't include the debian directory here yet. I need to figure out a few things first.
Some of these changes are quite disruptive so please let me know if this is a problem. As an example, the manpages have been moved from man1 to man7, according to the Debian policy: http://www.debian.org/doc/manuals/maint-guide/dother.en.html#manpage
Not sure if we can accept that or not.
Thanks,
Mathieu