session cookie/ID check #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This patch is independent from pull request #99. |
lategoodbye
reviewed
Jan 12, 2017
| @@ -126,6 +129,13 @@ signed VersionInfo2 (struct plc * plc) | |||
|
|
|||
| #endif | |||
|
|
|||
| #if 0 | |||
| /* firmware doesn't fill these fields properly, so don't check */ | |||
There was a problem hiding this comment.
Instead of adding more of these ugly #if 0, i suggest only a comment which clarify that the cookie value here isn't reliable.
There was a problem hiding this comment.
I replaced the #if with a comment.
Check confirmation MMEs for matching cookie/session-ID.
dvlemplgk
force-pushed
the
check-cookie
branch
from
09e6688 to
add3bd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check confirmation MMEs for matching cookie/session-ID.