Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appveyor configuration #118

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Add appveyor configuration #118

merged 2 commits into from
Jun 25, 2018

Conversation

wherget
Copy link
Contributor

@wherget wherget commented Jun 15, 2018

I just toyed around with Appveyor because I wanted to have a Windows build (and couldn't be bothered to set up Visual Studio). I thought I'd share my configuration in case you wanted to add Appveyor CI to make sure future changes build on Windows.

Maybe the Artifacts zip it generates should include README, LICENSE and NOTICES. What do you think?

I didn't want to go as far as configuring Github Release uploads, since I don't think there should be binaries around here, in order to avoid unneccessary support requests.

@mhei
Copy link
Contributor

mhei commented Jun 16, 2018

Very appreciated!

IMHO, we should include README and LICENSE.
NOTICES does not make sense for me because after the proclaimed license change this file is left only for historic reason?

I also would agree that official release builds is a no-go at the moment, due to missing official maintainer, versioning etc.

@wherget
Copy link
Contributor Author

wherget commented Jun 18, 2018

The package now includes README and LICENSE. See https://ci.appveyor.com/project/wherget/open-plc-utils/build/appveyor-ci-5/artifacts

Anything else you'd like to see?

@n1000 n1000 merged commit 933471a into qca:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants