plcstat/int6kstat: allow to query a powerline device for topology directly #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhei
force-pushed
the
plcstat-direct-query
branch
from
fb58f40 to
971eadb
Compare
mhei
changed the title
|
@n1000 @dvlemplgk @ch-aurich: would be nice if you could find the time for a review. Thanks. |
dvlemplgk
reviewed
Oct 5, 2018
plc/int6kstat.1
Outdated
| Topology is always relative to the local host, or local hosts if present. | ||
| Powerline devices that appear on the command line are not used for this operation. | ||
| PHY rates displaye by this option may saturate at 255 mbps. | ||
| Topology is relative to the queried powerline device(s) given on the command lines. If no device is given explicitely, |
dvlemplgk
reviewed
Oct 5, 2018
plc/plcstat.1
Outdated
| @@ -83,11 +82,13 @@ The default Link ID is \fB0xFC\fR. | |||
| .RB - t | |||
| Display network topology using VS_SW_VER and VS_NW_INFO messages. | |||
| This option is similar to option \fB-m\fR but provides complete network topology plus device hardware and firmware version. | |||
| Topology is always relative to the local host, or local hosts if present. | |||
| Powerline devices that appear on the command line are not used for this operation. | |||
| Topology is relative to the queried powerline device(s) given on the command lines. If no device is given explicitely, | |||
|
Functionality looks fine to me. There are some typos in the manual page (see inline comments). |
…ectly In a switched network, i.e. when local powerline device(s) are not connected directly to host, then using the Local Management Address to determine the local devices might fail due to wrong or incomplete forwarding by the switch. In this case it would be desirable to address the local powerline device directly which is not possible with both tools at the moment. This patch fixes this issue by keeping current behaviour as much as possible and also document it in the corresponding man pages. Signed-off-by: Michael Heimpold <[email protected]>
mhei
force-pushed
the
plcstat-direct-query
branch
from
971eadb to
22d1870
Compare
|
@dvlemplgk Thank you very much, I fixed the typos and pushed it to the branch. |
n1000
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a switched network, i.e. when local powerline device(s) are not
connected directly to host, then using the Local Management Address
to determine the local devices might fail due to wrong or incomplete
forwarding by the switch.
In this case it would be desirable to address the local powerline
device directly which is not possible with both tools at the moment.
This patch fixes this issue by keeping current behaviour as much as
possible and also document it in the corresponding man pages.
Signed-off-by: Michael Heimpold [email protected]